Chore: update to webpack 4 #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
kontrollanten
changed the title
|
Any comments? |
|
Confirming this works, please merge 👍 |
|
Could you please merge master into your branch? |
sapegin
reviewed
Mar 27, 2018
scripts/make-webpack-config.js
Outdated
| }, | ||
| mangle: { | ||
| keep_fnames: true, | ||
| optimization: { |
There was a problem hiding this comment.
No. I don't remember how this file is used. Will it be ran by the clients using react styleguidist? If it will, then I have to find a way to check for current webpack version.
There was a problem hiding this comment.
It generates a webpack configuration, there's a check already.
Fixes snyk errors due to old webpack-dev-server
This comment has been minimized.
This comment has been minimized.
sapegin
requested changes
Mar 28, 2018
package.json
Outdated
| @@ -85,7 +85,8 @@ | |||
| "type-detect": "^4.0.8", | |||
| "uglifyjs-webpack-plugin": "1.2.4", | |||
| "unist-util-visit": "^1.3.0", | |||
| "webpack-dev-server": "^2.9.7", | |||
| "webpack-cli": "^2.0.11", | |||
There was a problem hiding this comment.
I think this should be in dev dependencies.
scripts/make-webpack-config.js
Outdated
| }; | ||
| } else { | ||
| webpackConfig.plugins.unshift( | ||
| new UglifyJSPlugin({ |
There was a problem hiding this comment.
You can remove duplication here by moving Uglify options to a const.
sapegin
added a commit
that referenced
this pull request
Mar 31, 2018
👋 **[Support Styleguidist](https://opencollective.com/styleguidist) on Open Collective** 👋 ## Breaking changes ### Node 6 is the lowest supported version Styleguidist doesn’t support Node 4 anymore. (#744 #839 by @kohgpat) ### New format of template option We’re now using [mini-html-webpack-plugin](https://github.com/styleguidist/mini-html-webpack-plugin) and [@vxna/mini-html-webpack-template](https://github.com/vxna/mini-html-webpack-template) instead of [html-webpack-plugin](https://github.com/jantimon/html-webpack-plugin). This will make things like [adding a favicon](https://react-styleguidist.js.org/docs/cookbook#how-to-add-a-favicon) or fonts from [Google Fonts](https://react-styleguidist.js.org/docs/cookbook#how-to-add-fonts-from-google-fonts) much easier. If you’re using a custom HTML template, you need to update your style guide config. ```js // 6.x module.exports = { template: './styleguie/template.html' } // 7.x module.exports = { template: { // This is just an example, there are many more available options favicon: 'https://assets-cdn.github.com/favicon.ico' } } ``` See more [in the docs](https://react-styleguidist.js.org/docs/configuration#template). (#896 #907 by @sapegin) ### Changed Node API `server` method now returns an object containing a webpack `Compiler` instance and the Styleguidist server, see examples [in the docs](https://react-styleguidist.js.org/docs/api.html#servercallback). (#828 by @cmswalker) ## New features ### Webpack 4 support Webpack 3 is still supported too. (#857 by @kontrollanten, #900 #901 by @rubenmoya) ### Examples are wrapped in React.Fragment You don’t need to wrap multiple JSX tags in a div anymore. ```jsx // 6.x <div> <Button primary>Primary button</Button> <Button secondary>Secondary button</Button> </div> // 7.x <Button primary>Primary button</Button> <Button secondary>Secondary button</Button> ``` (#840 #842 by @tizmagik) ## Bug fixes * `components` option should accept arrays. * Do not convert URLs in Markdown to auto links (#793). * Improved accessibility (#893 by @gergely-nagy). --- ❤️ Huge thanks to @okonet to help with this release, [CI](#904) and [docs](#905) improvements.️ ❤️
|
🎉 This PR is included in version 7.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced May 9, 2020
Open
This was referenced Jul 9, 2020
Open
This was referenced Dec 2, 2020
Open
This was referenced Mar 13, 2022
Open
Open
This was referenced May 11, 2022
Open
This was referenced Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix snyk errors
Solves #856