Using devtools with react-stylegudist #456 #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `devtool` setting in your webpack config will now get passed through for non-production environments, e.g., running the hot-reloading server. It will still get ignored for production builds. Docs updated, and added a test.
Codecov Report
@@ Coverage Diff @@
## master #569 +/- ##
==========================================
+ Coverage 96.04% 96.04% +<.01%
==========================================
Files 99 99
Lines 1314 1316 +2
Branches 271 271
==========================================
+ Hits 1262 1264 +2
Misses 51 51
Partials 1 1
Continue to review full report at Codecov.
|
sapegin
requested changes
Aug 10, 2017
| @@ -38,3 +38,13 @@ it('should ignore certain Webpack plugins', () => { | |||
| expect(result.plugins[0].constructor.name).toBe('UglifyJsPlugin'); | |||
| expect(result.plugins[1].constructor.name).toBe('MyPlugin'); | |||
| }); | |||
|
|
|||
| [ | |||
There was a problem hiding this comment.
It would be almost shorter and much more readable if you write two separate tests without the loop ;-)
scripts/utils/mergeWebpackConfig.js
Outdated
| // For production builds, we'll ignore devtool settings to avoid | ||
| // source mapping bloat. | ||
| if (env === 'production') { | ||
| safeUserConfig = omit(safeUserConfig, ['devtool']); |
There was a problem hiding this comment.
I’d define a new const for that, like IGNORE_SECTIONS_PROD for consistency. Or even:
const IGNORE_SECTIONS_ENV = {
development: [],
production: ['devtool']
}In this case you could avoid a condition.
sapegin
approved these changes
Aug 10, 2017
|
Thanks, merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
devtoolsetting in your webpack config will now get passed through for non-production environments, e.g., running the hot-reloading server.It will still get ignored for production builds.
Docs updated, and added a test.