Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using devtools with react-stylegudist #456

Closed
benedyktdryl opened this issue May 26, 2017 · 8 comments
Closed

Using devtools with react-stylegudist #456

benedyktdryl opened this issue May 26, 2017 · 8 comments

Comments

@benedyktdryl
Copy link

Hi,

I know that devtools are ignored along with some other configuration keys.

My question is:

  • Is there any particular reason for that? Is it breaking react-stylegudist entirely or there are some edge cases?
  • Can we disable ignoring somehow or you will consider PR with disabling it optionally feature?
  • Is there kind of recipe for having sourcemaps on development when using your library?

Thanks for your time!

@benedyktdryl benedyktdryl changed the title Disable ignoring devtools configuraiton Using devtools with react-stylegudist May 26, 2017
@sapegin
Copy link
Member

sapegin commented May 27, 2017

For devtools it should not be necessary, so feel free to send a pull request ;-)

The only thing I’m not sure about is the production build: should we disable sourcemaps in this case?

@benedyktdryl
Copy link
Author

So I should go with optional disabling ignoring or I can just remove devtools from ignored keys list?

@sapegin
Copy link
Member

sapegin commented May 30, 2017

@n1313 Did you want to be able to change devtools? What should we do for production build?

@n1313
Copy link
Collaborator

n1313 commented May 30, 2017 via email

@sapegin
Copy link
Member

sapegin commented May 30, 2017

@n1313 Sorry, it was @cef62 ;-)

@n1313
Copy link
Collaborator

n1313 commented May 30, 2017 via email

@benedyktdryl
Copy link
Author

Any updates on that?

CC: @cef62 @sapegin

@sapegin
Copy link
Member

sapegin commented Jun 7, 2017

I think it should explicitly disable devtool in production, otherwise it would complicate style guide configuration and will be easy to miss.

AttackTheDarkness pushed a commit to AttackTheDarkness/react-styleguidist that referenced this issue Aug 9, 2017
The `devtool` setting in your webpack config will now get passed through for non-production environments, e.g., running the hot-reloading server.

It will still get ignored for production builds.

Docs updated, and added a test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants