Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix - partial fix for #879 #1126

Closed
wants to merge 1 commit into from
Closed

Conversation

Jlevyd15
Copy link

@Jlevyd15 Jlevyd15 commented Sep 3, 2018

Background

  • improves accessibility in the example application for various components
  • to meet WCAG 2.0 color contrast requirements foreground/background must have a ratio of 4.5.1 or greater see docs HERE
  • using aXe chrome plugin for testing more info. HERE

Changes

  • side-bar navigation links, darkened link color #1978c8 -> #1873bf
  • PropType table, darkened prop name color #7f9a44 -> #667c36
  • PropType table, darkened type color #b77daa -> #a15994
  • VersionRenderer - changed the text color from color.light -> color.error

- improves accessibility in the example application for various components
- to meet WCAG 2.0 color contrast requirements foreground/background must have a ratio of 4.5.1 or greater
- side-bar navigation links, darkened link color #1978c8 -> #1873bf
- PropType table, darkened prop ```name``` color #7f9a44 -> #667c36
- PropType table, darkened ```type``` color #b77daa -> #a15994
- VersionRenderer - changed the text color from ```color.light``` -> ```color.error```
@Jlevyd15 Jlevyd15 mentioned this pull request Sep 3, 2018
4 tasks
@sapegin
Copy link
Member

sapegin commented Sep 3, 2018

Thanks! This is very good kind of PR! Could you please have a look at the next branch, I've changed a few colors there, and sidebar links and props table should already WCAG 2.0 compliant.

And we probably need to add another shade of gray text — using error color is incorrect here, and it's way to bright for such thing as version number.

@stale
Copy link

stale bot commented Dec 28, 2018

😴 This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week without any further activity. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants