Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve accessibility #879

Closed
4 tasks done
sapegin opened this issue Mar 20, 2018 · 4 comments
Closed
4 tasks done

Improve accessibility #879

sapegin opened this issue Mar 20, 2018 · 4 comments
Labels
good first issue Good for newcomers help wanted released request for comments

Comments

@sapegin
Copy link
Member

sapegin commented Mar 20, 2018 •
edited
Loading

To do

(Will be done in #893)

  • Tweak colors to comply with WCAG 2 AA contrast ratio (gray text, for example).
  • Add an invisible label to the search field (aria-label).
  • Add eslint-plugin-jsx-a11y

To think

  • Missing lang attribute in html tag. Do we need a config option for that?

Am I missing anything?

/cc @okonet
@gergely-nagy
Copy link
Contributor

I'd like to jump in on this! 🚀

@sapegin
Copy link
Member Author

sapegin commented Mar 23, 2018

@gergely-nagy Awesome! 🦄

@gergely-nagy gergely-nagy mentioned this issue Mar 25, 2018
Merged
@sapegin sapegin modified the milestone: 7.0.0 Mar 28, 2018
Jlevyd15 pushed a commit to Jlevyd15/react-styleguidist that referenced this issue Sep 3, 2018
fix - partial fix for styleguidist#879
4bd0c48 
- improves accessibility in the example application for various components
- to meet WCAG 2.0 color contrast requirements foreground/background must have a ratio of 4.5.1 or greater
- side-bar navigation links, darkened link color #1978c8 -> #1873bf
- PropType table, darkened prop ```name``` color #7f9a44 -> #667c36
- PropType table, darkened ```type``` color #b77daa -> #a15994
- VersionRenderer - changed the text color from ```color.light``` -> ```color.error```
@Jlevyd15
Copy link

Jlevyd15 commented Sep 3, 2018

@sapegin noticed a few color contrast issues with the example Styleguide docs. I've created a PR #1126 to address those. I figured those would land within the scope of this issue but if you think it needs a separate issue let me know.

sapegin pushed a commit that referenced this issue Sep 18, 2018
@aghh1504 @sapegin
Chore: Add eslint-plugin-jsx-a11y (#1138)
08a9133 
Part of #879
@styleguidist-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 11.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted released request for comments
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sapegin @Jlevyd15 @gergely-nagy @styleguidist-bot