Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate inline styles for the block editor from theme support declarations #198

Merged
merged 14 commits into from
Mar 14, 2019

Conversation

nickcernis
Copy link
Collaborator

Draft PR with work in progress for #187.

@nickcernis nickcernis marked this pull request as ready for review March 13, 2019 13:43
@nickcernis
Copy link
Collaborator Author

@dreamwhisper This is now ready for review. I'd especially appreciate some testing of the button colors if you have time.

To introduce the Customizer colors to the Block Editor color palette, I had to introduce some new button styles (based very heavily on work we'd already tested in Altitude). I've also dropped the gray colors and set the blue button as the default.

This will have an impact on screenshots on docs and sales pages.

@nickcernis nickcernis requested a review from dreamwhisper March 13, 2019 13:53
nickcernis and others added 3 commits March 13, 2019 21:13
Fixes an issue @dreamwhisper discovered where changing Customizer
colors would not update button colors in the preview until changes
are published.
Copy link
Contributor

@dreamwhisper dreamwhisper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nickcernis The button fix in the customizer is working well for me!

I added a couple of commits for admin editor styles to fix a couple of additional issues. I'm not seeing anything else related to this at the moment so if you're good with the commits I made, feel free to merge.

@nickcernis
Copy link
Collaborator Author

@dreamwhisper Thanks for the test and the additional fixes!

@nickcernis nickcernis merged commit 6c2d56f into develop Mar 14, 2019
@nickcernis nickcernis deleted the feature/inline-block-editor-styles branch March 14, 2019 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants