-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate inline styles for the block editor from theme support declarations #198
Conversation
TODO: test and adapt inline styles for use in Genesis Sample.
The block editor does not emit inline styles for the 'normal' size.
- Equivalent front-end CSS is now added in `inline-styles.php`. - Editor CSS is now added inline by WordPress.
@dreamwhisper This is now ready for review. I'd especially appreciate some testing of the button colors if you have time. To introduce the Customizer colors to the Block Editor color palette, I had to introduce some new button styles (based very heavily on work we'd already tested in Altitude). I've also dropped the gray colors and set the blue button as the default. This will have an impact on screenshots on docs and sales pages. |
Fixes an issue @dreamwhisper discovered where changing Customizer colors would not update button colors in the preview until changes are published.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nickcernis The button fix in the customizer is working well for me!
I added a couple of commits for admin editor styles to fix a couple of additional issues. I'm not seeing anything else related to this at the moment so if you're good with the commits I made, feel free to merge.
@dreamwhisper Thanks for the test and the additional fixes! |
Draft PR with work in progress for #187.