-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Editor: automatically generate inline CSS for editor theme supports #187
Comments
That sounds like a wonderful idea. |
This sounds scary... I'm not necessarily opposed to it, but I am concerned with anything generating inline styles that might over-ride existing child theme CSS. What "inline CSS" specifically is going to get injected based on theme supports? (I obviously haven't seen the unreleased updates) |
@jb510 Nothing scary, just removing the need to add CSS like this manually: genesis-sample/lib/gutenberg/front-end.css Lines 4 to 18 in 71e85dd
As that CSS can already be inferred from: genesis-sample/config/editor-font-sizes.php Lines 13 to 34 in 71e85dd
Same with Also, in case you hadn't spotted it, this proposal is for the Genesis Sample repo. You could remove it if you didn't want to use it, and it won't affect Genesis itself/other child themes at present. |
Ugh, I'll be more careful, that's the second time I mistook an issue for Genesis Sample as an issue for Genesis core... Sorry. |
@jb510 No problem! Thanks for taking an interest in this stuff and for sharing your thoughts. |
Work on this has now been merged into develop in #198. This will form part of the Genesis Sample 2.9.0 release planned for late this week. |
In recent (unreleased) StudioPress theme updates, we've started generating Gutenberg inline CSS code on the front and back that can be inferred automatically from theme supports such as
editor-font-sizes
andeditor-color-palettes
.I'd like to explore doing the same in Genesis Sample to reduce the amount of Gutenberg-related CSS people have to write when using Sample as a starting point for their themes.
The text was updated successfully, but these errors were encountered: