Fix release tag calculation #1567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamil-stripe
approved these changes
Sep 29, 2022
kamil-stripe
added a commit
that referenced
this pull request
Oct 6, 2022
* Migrate other Stripe infrastructure to TS * Reviewer comments * Update TypeScript * Reviewer comments * Remove 'use strict' from migrated files * Turn on alwaysStrict in tsconfig * Update src/net/NodeHttpClient.ts Co-authored-by: Kamil Pajdzik <[email protected]> * Update src/crypto/SubtleCryptoProvider.ts Co-authored-by: Kamil Pajdzik <[email protected]> * Update src/crypto/SubtleCryptoProvider.ts Co-authored-by: Kamil Pajdzik <[email protected]> * Remove hasOwn alias, undo suggested commits * Update src/net/FetchHttpClient.ts Co-authored-by: Kamil Pajdzik <[email protected]> * Add more types to HTTP clients * API Updates (#1564) Codegen for openapi v197 * Bump version to 10.12.0 * Fix release tag calculation (#1567) * Upgrade dev dependencies (#1568) * Upgrade @types/node * Upgrade @typescript-eslint/eslint-plugin * Upgrade @typescript-eslint/parser * Upgrade eslint * Lint * Add ESLint congif for TS tests * Add Node configuration to ESLint configuration * Remove 'Function' declaration * Downgrade lint packages and suppress lint errors * Upgrade ansi-regex * Downgrade @typescript-eslint/parser * Reset angi-regex * Yarn.lock * Upgrade chai * Upgrade mocha * Downgrade mocha * Add ^ * Upgrade eslint-config-prettier * Upgrade eslint-plugin-chai-friendly * Upgrade eslint-plugin-prettier * Downgrade eslint-plugin-prettier * Remove ansi-regex * Upgrade typescript * Upgrade mocha-junit-reporter * Upgrade qs * Upgrade prettier * Upgrade nock * Formatting * Downgrade prettier * Lint * Upgrade nanoid * Revert nanoid * Upgrade node-fetch * Downgrade node-fetch * Revert types/node change * Revert fetch type * Update node-fetch to 2.6.7 (#1570) * Update node-fetch to 2.6.7 * Yarn.lock * Formatting * Lint * API Updates (#1571) Codegen for openapi v201 * Bump version to 10.13.0 * Set version to 10.13.0 to simplify merge * Reset version to 10.12.0-beta.1 * Codegen for openapi v201 Co-authored-by: Annie Li <[email protected]> Co-authored-by: anniel-stripe <[email protected]> Co-authored-by: yejia-stripe <[email protected]> Co-authored-by: Yejia Chen <[email protected]> Co-authored-by: pakrym-stripe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
npm -s run env echo '$npm_package_version'just stopped working at some point resulting in us pushing packages with the wrong tag.Use a method that doesn't depend on magic env variables.
You can see me testing both methods in https://github.com/stripe/stripe-node/actions/runs/3152261690/jobs/5127251959
Fixes: #1566