Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latest version is not aligned on github / npm #1566

Closed
rafipiccolo opened this issue Sep 29, 2022 · 1 comment · Fixed by #1567
Closed

latest version is not aligned on github / npm #1566

rafipiccolo opened this issue Sep 29, 2022 · 1 comment · Fixed by #1567
Assignees
Labels

Comments

@rafipiccolo
Copy link

rafipiccolo commented Sep 29, 2022

Describe the bug

here on npm : latest is 10.12.0-beta.1
and here on github : it is still v10.11.0
latest tag should be aligned, and should not not be the beta version. IMHO

To Reproduce

jst go check on theses urls
https://www.npmjs.com/package/stripe
https://github.com/stripe/stripe-node/releases

Expected behavior

Latest should be the same version on github and npm,
and it should not a beta version.

by the way, i'll create another issuefor this.
but it introduces a breaking changes since i got this message when i create a payment.
You cannot use line_items.amount, line_items.currency, line_items.name, line_items.description, or line_items.images in this API version. Please use line_items.price or line_items.price_data. Please see https://stripe.com/docs/payments/
(this is one reason why i think a beta version should not be latest)

Code snippets

No response

OS

ubuntu

Node version

18.10.0

Library version

10.12.0-beta.1

API version

2022-08-01

Additional context

No response

@pakrym-stripe
Copy link
Contributor

Agreed, this is a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants