chore(issues): replace Issues.txt with multi-repo service improvements#7
chore(issues): replace Issues.txt with multi-repo service improvements#7
Conversation
Adds 10 issues covering identified gaps and improvements for making the Workflows repository a proper multi-repo CI service: 1. Create floating v1 tag for stable consumer pinning 2. Add working-directory input for monorepo support 3. Document workflow outputs in Integration Guide 4. Add input validation step to reusable workflows 5. Create Node.js/TypeScript reusable CI workflow 6. Parallelize lint steps in Python CI workflow 7. Add conditional tool installation based on input flags 8. Create GitHub starter workflow template 9. Add backward compatibility policy documentation 10. Create integration test consumer repository Issues formatted for Agents 63 Issue Intake workflow.
|
Gate fast-pass: docs-only change detected; heavy checks skipped. |
Automated Status SummaryHead SHA: 9d47bcf
Updated automatically; will refresh on subsequent CI/Docker completions. Keepalive checklistScope
Tasks
Acceptance criteria
|
There was a problem hiding this comment.
Pull request overview
This PR replaces the old Issues.txt file containing 2 project-specific cleanup tasks with 10 new issues focused on transforming the Workflows repository into a comprehensive multi-repo CI service. The new issues cover versioning, monorepo support, documentation, validation, feature expansion, performance optimization, and testing improvements.
Key changes:
- Completely replaces previous issues with 10 new strategic improvements
- Shifts focus from project-specific cleanup to multi-repo service enhancements
- Maintains consistent formatting for the Agents 63 Issue Intake workflow
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Fix tomlkit isinstance checks - use hasattr for duck typing (#3) - Add type validation for python_version before str() conversion (#6) - Fix redundant ternary operators in agents-guard.yml (3 instances) (#1) - Fix authorIsCodeowner indentation in agents-guard.js (#4) - Fix inconsistent array indentation in agents-guard.js (#5) - Remove redundant instructions=[] reassignment in agents-guard.js (#7) - Fix typo in keepalive_loop.js numbered list comment (#9) All fixes applied to both main files and templates/consumer-repo. See docs/CODE_QUALITY_ISSUES.md for issue tracking.
* fix: address code quality issues from Copilot reviews - Fix tomlkit isinstance checks - use hasattr for duck typing (#3) - Add type validation for python_version before str() conversion (#6) - Fix redundant ternary operators in agents-guard.yml (3 instances) (#1) - Fix authorIsCodeowner indentation in agents-guard.js (#4) - Fix inconsistent array indentation in agents-guard.js (#5) - Remove redundant instructions=[] reassignment in agents-guard.js (#7) - Fix typo in keepalive_loop.js numbered list comment (#9) All fixes applied to both main files and templates/consumer-repo. See docs/CODE_QUALITY_ISSUES.md for issue tracking. * chore: archive resolved CODE_QUALITY_ISSUES.md
- Fix tomlkit isinstance checks - use hasattr for duck typing (#3) - Add type validation for python_version before str() conversion (#6) - Fix redundant ternary operators in agents-guard.yml (3 instances) (#1) - Fix authorIsCodeowner indentation in agents-guard.js (#4) - Fix inconsistent array indentation in agents-guard.js (#5) - Remove redundant instructions=[] reassignment in agents-guard.js (#7) - Fix typo in keepalive_loop.js numbered list comment (#9) All fixes applied to both main files and templates/consumer-repo. See docs/CODE_QUALITY_ISSUES.md for issue tracking.
* fix: address code quality issues from Copilot reviews - Fix tomlkit isinstance checks - use hasattr for duck typing (#3) - Add type validation for python_version before str() conversion (#6) - Fix redundant ternary operators in agents-guard.yml (3 instances) (#1) - Fix authorIsCodeowner indentation in agents-guard.js (#4) - Fix inconsistent array indentation in agents-guard.js (#5) - Remove redundant instructions=[] reassignment in agents-guard.js (#7) - Fix typo in keepalive_loop.js numbered list comment (#9) All fixes applied to both main files and templates/consumer-repo. See docs/CODE_QUALITY_ISSUES.md for issue tracking. * chore: archive resolved CODE_QUALITY_ISSUES.md * fix: prevent useless follow-up issues when source lacks criteria Add isMissingInfoGap() to detect verifier gaps that are about missing source info rather than actual verification failures. These gaps (like 'Provide explicit acceptance criteria in the PR description') indicate the source issue/PR lacked structured criteria, not that verification found actual problems. Updated hasSubstantiveContent check to filter out these 'missing info' gaps, preventing creation of follow-up issues when there's nothing actionable to fix. Fixes issue #415 scenario where follow-up issues were created despite having only placeholder content because the verifier gaps were about missing source info. Added 7 new tests: - isMissingInfoGap() unit tests - Integration tests for hasSubstantiveContent with missing info gaps * fix: resolve mypy union-attr errors in resolve_mypy_pin.py Use dict() to normalize tomlkit Table objects with type: ignore[call-overload] comments to satisfy mypy type checking while preserving duck-typing compatibility with tomlkit's custom container types. Fixes mypy errors: tools/resolve_mypy_pin.py:36: error: Item "None" has no attribute "get" [union-attr] tools/resolve_mypy_pin.py:39: error: Item "None" has no attribute "get" [union-attr] * fix: broaden type ignore to cover both arg-type and call-overload Different mypy versions report different error codes for the same issue. Use a combined ignore comment to handle both. * fix: address bot review comments from PR #417 1. Remove redundant /i regex flags in isMissingInfoGap() since text is already lowercased via .toLowerCase() 2. Improve numbered list comment in keepalive_loop.js to clarify both 1., 2., 3. and 1), 2), 3) formats are matched 3. Fix ALL remaining redundant ternary operators for Number() conversion: - agents-guard.yml (3 instances - lines 314, 442 fixed) - health-44-gate-branch-protection.yml (1 instance) - agents_pr_meta_update_body.js (1 instance) - templates/consumer-repo agents-guard.yml (2 instances) 4. Add missing tests for formatSimpleFollowUpIssue hasSubstantiveContent with missing info gaps (2 new test cases)
Adds 10 issues covering identified gaps and improvements for making the Workflows repository a proper multi-repo CI service:
Issues formatted for Agents 63 Issue Intake workflow.
Automated Status Summary
Scope
tests/workflows/are excluded from CI and local runs because they import modules from Trend_Model_Project that don't exist in this repository (e.g.,scripts.mypy_return_autofix,scripts.fix_cosmetic_aggregate,scripts.update_autofix_expectations). This represents ~50% of the Python test suite being skipped.Tasks
[tool.ruff] excludein pyproject.toml.--ignoreflags from selftest-ci.yml Python test step.Acceptance criteria
python -m pytest tests/workflows/ -vruns without collection errors.Head SHA: 976b4e8
Latest Runs: ✅ success — Gate
Required: gate: ✅ success