fix: sync autofix-versions.env template and fix devcontainer PATH#962
Merged
fix: sync autofix-versions.env template and fix devcontainer PATH#962
Conversation
Fixes based on review comments on sync PRs:
1. Add missing non_goals section to SECTION_ALIASES/SECTION_TITLES
- Aligns with issue_formatter.py for consistent section parsing
- Now properly recognizes 'Non-Goals', 'Out of scope', etc.
2. Fix _parse_sections to reset current at unrecognized headings
- Previously, content under '## Out of scope' would be appended to
the previous recognized section (e.g., Tasks)
- Now terminates section capture at any heading, recognized or not
3. Add docstrings to all helper functions
- _normalize_heading, _resolve_section, _parse_sections
- _strip_checkbox, _parse_checklist
4. Fix redundant regex matching in _parse_checklist
- Pass pre-computed LIST_ITEM_REGEX match to _strip_checkbox
- Avoids matching the same regex twice per line
All 18 existing tests pass.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
The previous fix incorrectly reset 'current' for ALL headings, which would discard content under subheadings like: - [ ] Task 1 - [ ] Task 2 Now only top-level headings (# and ##) trigger section transitions. Subheadings (###, ####, etc.) are preserved as content within the section. Also fixed the docstring comment to use 'Random Notes' as an example of an unrecognized heading, since 'Out of scope' is now a recognized alias for non_goals.
- Update templates/consumer-repo autofix-versions.env to match source - BLACK_VERSION: 25.12.0 -> 26.1.0 - RUFF_VERSION: 0.14.11 -> 0.14.13 - Fix devcontainer.json to use pip-installed tool versions - Add containerEnv to prepend ~/.local/bin to PATH - Remove stale system tools from /usr/local/py-utils/bin This fixes the version drift that caused autofix to push formatting that didn't match CI checks. The devcontainer image ships with old versions of black/ruff in /usr/local/py-utils/bin which took precedence over the pip-installed versions from pyproject.toml. Root cause: Template autofix-versions.env was not being kept in sync with the main Workflows autofix-versions.env source of truth.
stranske
temporarily deployed
to
agent-standard
GitHub Actions
Inactive
github-actions
bot
added
the
autofix
The script now checks and syncs templates/consumer-repo/.github/workflows/autofix-versions.env to match the source file. This ensures the maint-68 sync workflow always has the correct versions to push to consumer repos. Root cause of version drift: The template file was never automatically synced from the source, so when BLACK_VERSION was updated in .github/workflows/autofix-versions.env, the template stayed at the old version and got synced to consumers.
Contributor
|
Status | ✅ no new diagnostics |
Contributor
Automated Status SummaryHead SHA: 435cc78
Coverage Overview
Coverage Trend
Top Coverage Hotspots (lowest coverage)
Updated automatically; will refresh on subsequent CI/Docker completions. Keepalive checklistScopeIntegration Sync Drift DetectedThe Workflows-Integration-Tests repo has drifted from the templates in this repo. Check Details: Run #6 Required ActionsContext for AgentDesign Decisions & Constraints
Related Issues/PRsReferences
Tasks
Acceptance criteria
|
stranske
temporarily deployed
to
agent-standard
GitHub Actions
Inactive
Contributor
🤖 Keepalive Loop StatusPR #962 | Agent: Codex | Iteration 0/5 Current State
🔍 Failure Classification| Error type | infrastructure | |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 88b7e10dcb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical issue where the template autofix-versions.env file was outdated, causing the sync workflow to push stale tool versions to consumer repos. It also fixes a devcontainer PATH ordering issue that caused system-installed tools to take precedence over pip-installed versions. Additionally, it includes improvements to the issue parser for handling non-goals sections and subheadings.
Changes:
- Updated BLACK_VERSION (25.12.0 → 26.1.0) and RUFF_VERSION (0.14.11 → 0.14.13) in the template to match the source
- Fixed devcontainer PATH by prepending ~/.local/bin via containerEnv and removing stale system tools
- Enhanced issue parsing to support non-goals sections and properly handle subheadings within sections
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| templates/consumer-repo/.github/workflows/autofix-versions.env | Synced BLACK and RUFF versions from source to template to fix sync workflow |
| .devcontainer/devcontainer.json | Added containerEnv to fix PATH ordering and remove stale system tools |
| scripts/langchain/followup_issue_generator.py | Added non_goals section support and improved section parsing to handle subheadings |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Add autouse fixture to disable template sync in existing tests - Add tests for template mismatch detection and sync functionality
stranske
temporarily deployed
to
agent-standard
GitHub Actions
Inactive
- Fix heading regex to match ### (used by GitHub issue forms) not just # and ## - Remove unused non_goals section from SECTION_ALIASES and SECTION_TITLES (was added but never extracted/stored, causing silent data loss)
Keep #{1,3} regex to support GitHub issue forms (###)
stranske
temporarily deployed
to
agent-high-privilege
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated Status Summary
Scope
Integration Sync Drift Detected
The Workflows-Integration-Tests repo has drifted from the templates in this repo.
Check Details: Run #6
Required Actions
Context for Agent
Design Decisions & Constraints
Related Issues/PRs
References
Tasks
templates/integration-repo/to match Integration-Tests changesAcceptance criteria
maint-65-sync-label-docs.ymlpattern for automated syncHead SHA: 5aec033
Latest Runs: ✅ success — Gate
Required: gate: ✅ success