fix: inline python-ci-setup composite action for external repo compat…#49
Merged
fix: inline python-ci-setup composite action for external repo compat…#49
Conversation
…ibility Composite actions with relative paths (./.github/actions/...) don't work when external repos call reusable workflows - the path resolves to the caller's repo, not the Workflows repo. This change inlines the python-ci-setup action steps directly into reusable-10-ci-python.yml at all 4 usage locations: - lint-format job - lint-ruff job - typecheck-mypy job - tests job Each inlined block includes: - actions/setup-python@v5 - actions/setup-node@v4 - uv installation - uv cache (conditional) - dependency installation script External consumer repos can now call the reusable workflow without needing any local composite actions.
Owner
Author
Contributor
Automated Status SummaryHead SHA: 0ce6694
Coverage Overview
Coverage Trend
Updated automatically; will refresh on subsequent CI/Docker completions. Keepalive checklistScopeNo scope information available Tasks
Acceptance criteria
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses an external repository compatibility issue by inlining the .github/actions/python-ci-setup composite action directly into the reusable-10-ci-python.yml workflow. Composite actions with relative paths don't work when called from external repositories, as the path resolves to the caller's repository rather than the Workflows repository.
Key Changes:
- Removed 4 calls to the
python-ci-setupcomposite action across different jobs - Inlined the complete setup logic (Python, Node.js, uv installation, caching, and dependency management) at each location
- Adapted environment variable handling to work directly in workflow steps rather than through composite action inputs
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
stranske
pushed a commit
that referenced
this pull request
Dec 27, 2025
When copying agents-63-issue-intake.yml from Workflows to consumer repos, it contains a LOCAL reference to reusable-agents-issue-bridge.yml that doesn't exist in consumer repos and will cause issue intake to fail. Added: 1. Critical warning in section 4.1b with: - Explanation of the problem - Before/after code showing what to change - Alternative: copy from Template instead (already correct) 2. New item #5 in Common Mistakes section This was discovered when Manager-Database issue #49 and trip-planner issue intake failed after copying agents-63-issue-intake.yml directly from Workflows without fixing the local reference.
25 tasks
stranske
added a commit
that referenced
this pull request
Dec 27, 2025
When copying agents-63-issue-intake.yml from Workflows to consumer repos, it contains a LOCAL reference to reusable-agents-issue-bridge.yml that doesn't exist in consumer repos and will cause issue intake to fail. Added: 1. Critical warning in section 4.1b with: - Explanation of the problem - Before/after code showing what to change - Alternative: copy from Template instead (already correct) 2. New item #5 in Common Mistakes section This was discovered when Manager-Database issue #49 and trip-planner issue intake failed after copying agents-63-issue-intake.yml directly from Workflows without fixing the local reference. Co-authored-by: GitHub Copilot <copilot@github.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ibility
Composite actions with relative paths (./.github/actions/...) don't work when external repos call reusable workflows - the path resolves to the caller's repo, not the Workflows repo.
This change inlines the python-ci-setup action steps directly into reusable-10-ci-python.yml at all 4 usage locations:
Each inlined block includes:
External consumer repos can now call the reusable workflow without needing any local composite actions.