Skip to content

docs: Add critical warning about reusable workflow references in SETUP_CHECKLIST#216

Merged
stranske merged 1 commit intomainfrom
fix/setup-checklist-reusable-reference
Dec 27, 2025
Merged

docs: Add critical warning about reusable workflow references in SETUP_CHECKLIST#216
stranske merged 1 commit intomainfrom
fix/setup-checklist-reusable-reference

Conversation

@stranske
Copy link
Copy Markdown
Owner

@stranske stranske commented Dec 27, 2025

Automated Status Summary

Scope

  • scripts/validate_fast.sh contains 12 TODO Phase 4 markers referencing Trend_Model_Project-specific features (SRC_FILES detection, autofix tests, coverage requirements) that are not applicable to this workflow repository. These dead code paths and stale references cause confusion and add maintenance burden.

Tasks

  • Remove all TODO Phase 4 markers and their associated dead/commented code blocks.
  • Remove SRC_FILES and AUTOFIX_FILES detection logic that references src/ directory patterns not present in this repo.
  • Update linting targets to use scripts/ and .github/ instead of src/ tests/.
  • Replace Python package-specific validation (coverage requirements, import tests) with workflow-specific checks (actionlint, YAML validation).
  • Ensure the script still runs successfully after cleanup.

Acceptance criteria

  • - grep -c "TODO Phase" scripts/validate_fast.sh returns 0.
  • - Script executes without errors: bash scripts/validate_fast.sh --help works.
  • - No references to src/ directory or Trend_Model_Project-specific patterns remain.
  • - Validation targets are appropriate for a workflow repository (scripts/, .github/).
  • Head SHA: 4ace6aa
  • Latest Runs: ❔ startup failure — Gate
  • Required: gate: ❔ startup failure
  • | Workflow / Job | Result | Logs |
  • |----------------|--------|------|
  • | Agents PR meta manager | ❔ in progress | View run |
  • | CI Autofix Loop | ✅ success | View run |
  • | Gate | ❔ startup failure | View run |
  • | Health 40 Sweep | ✅ success | View run |
  • | Health 44 Gate Branch Protection | ❌ failure | View run |
  • | Health 45 Agents Guard | ✅ success | View run |
  • | Health 50 Security Scan | ✅ success | View run |
  • | Maint 52 Validate Workflows | ✅ success | View run |
  • | PR 11 - Minimal invariant CI | ✅ success | View run |
  • | Selftest CI | ✅ success | View run |

Head SHA: f430e2f
Latest Runs: ⏳ queued — Gate
Required: gate: ⏳ queued

Workflow / Job Result Logs
Agents PR meta manager ❔ in progress View run
CI Autofix Loop ✅ success View run
Copilot code review ⏳ queued View run
Gate ⏳ queued View run
Health 40 Sweep ✅ success View run
Health 44 Gate Branch Protection ❔ in progress View run
Health 45 Agents Guard ✅ success View run
Health 50 Security Scan ❔ in progress View run
Maint 52 Validate Workflows ✅ success View run
PR 11 - Minimal invariant CI ✅ success View run
Selftest CI ❔ in progress View run

When copying agents-63-issue-intake.yml from Workflows to consumer repos,
it contains a LOCAL reference to reusable-agents-issue-bridge.yml that
doesn't exist in consumer repos and will cause issue intake to fail.

Added:
1. Critical warning in section 4.1b with:
   - Explanation of the problem
   - Before/after code showing what to change
   - Alternative: copy from Template instead (already correct)

2. New item #5 in Common Mistakes section

This was discovered when Manager-Database issue #49 and trip-planner
issue intake failed after copying agents-63-issue-intake.yml directly
from Workflows without fixing the local reference.
Copilot AI review requested due to automatic review settings December 27, 2025 21:47
@agents-workflows-bot
Copy link
Copy Markdown
Contributor

⚠️ Action Required: Unable to determine source issue for PR #216. The PR title, branch name, or body must contain the issue number (e.g. #123, branch: issue-123, or the hidden marker ).

@github-actions
Copy link
Copy Markdown
Contributor

Gate fast-pass: docs-only change detected; heavy checks skipped.

@github-actions
Copy link
Copy Markdown
Contributor

Automated Status Summary

Head SHA: 8d9e85b
Latest Runs: ⏳ pending — Gate
Required contexts: Gate / gate, Health 45 Agents Guard / Enforce agents workflow protections
Required: core tests (3.11): ⏳ pending, core tests (3.12): ⏳ pending, docker smoke: ⏳ pending, gate: ⏳ pending

Workflow / Job Result Logs
(no jobs reported) ⏳ pending

Updated automatically; will refresh on subsequent CI/Docker completions.


Keepalive checklist

Scope

No scope information available

Tasks

  • No tasks defined

Acceptance criteria

  • No acceptance criteria defined

@github-actions
Copy link
Copy Markdown
Contributor

🤖 Keepalive Loop Status

PR #216 | Agent: Codex | Iteration 0/5

Current State

Metric Value
Iteration progress [----------] 0/5
Action wait (missing-agent-label)
Gate success
Tasks 9/24 complete
Keepalive ❌ disabled
Autofix ❌ disabled

🔍 Failure Classification

| Error type | infrastructure |
| Error category | resource |
| Suggested recovery | Confirm the referenced resource exists (repo, PR, branch, workflow, or file). |

@stranske stranske merged commit 12facf3 into main Dec 27, 2025
50 checks passed
@stranske stranske deleted the fix/setup-checklist-reusable-reference branch December 27, 2025 21:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds critical documentation to prevent a common setup failure where the agents-63-issue-intake.yml workflow file contains a local reference to reusable-agents-issue-bridge.yml that doesn't exist in consumer repositories, causing silent failures in issue intake.

  • Added a prominent warning with clear before/after examples in section 4.1b
  • Added item #5 to the Common Mistakes troubleshooting section
  • Includes an alternative approach suggesting copying from the Template repo instead

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

2. **Missing commit status** — Keepalive checks for `Gate / gate` status to know when CI passes
3. **Wrong workflow name in trigger** — The `workflows:` array must match the exact workflow `name:` field
4. **Missing scripts** — Scripts are NOT automatically synced; they must exist in consumer repo
5. **Local reusable workflow references** — When copying `agents-63-issue-intake.yml` from Workflows, it has a LOCAL reference to `reusable-agents-issue-bridge.yml` that doesn't exist in consumer repos. Must change to remote reference: `stranske/Workflows/.github/workflows/reusable-agents-issue-bridge.yml@main`
Copy link

Copilot AI Dec 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is excessively long (over 270 characters) and difficult to read. Consider breaking it into multiple lines or condensing the explanation since the full details are already documented in section 4.1b. The Common Mistakes section should be a quick reference with brief descriptions.

Suggested change
5. **Local reusable workflow references**When copying `agents-63-issue-intake.yml` from Workflows, it has a LOCAL reference to `reusable-agents-issue-bridge.yml` that doesn't exist in consumer repos. Must change to remote reference: `stranske/Workflows/.github/workflows/reusable-agents-issue-bridge.yml@main`
5. **Local reusable workflow references**`agents-63-issue-intake.yml` uses a local `reusable-agents-issue-bridge.yml`; in consumer repos update to remote `stranske/Workflows/.github/workflows/reusable-agents-issue-bridge.yml@main`

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants