fix(sync): repair generated review and dependency drift - #2908
Merged
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
📝 WalkthroughWalkthroughThe change improves tamper-check failure reporting, preserves boolean verifier verdict fields, strengthens benchmark override validation, and updates coverage pins in canonical and template configurations. ChangesVerifier and tooling updates
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant verify_spec
participant _changed_assertions
participant subprocess
verify_spec->>_changed_assertions: run tamper check
_changed_assertions->>subprocess: execute Git command
subprocess-->>_changed_assertions: raise CalledProcessError
_changed_assertions-->>verify_spec: return command and process diagnostics
verify_spec-->>verify_spec: create FAIL_BROKEN verdict
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
stranske
temporarily deployed
to
agent-high-privilege
August 4, 2026 02:45 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
This PR repairs sync- and drift-related regressions across the deliberate-break verifier surface, model benchmark policy validation, and pinned coverage toolchain versions so canonical Workflows and the consumer/integration templates remain aligned.
Changes:
- Make deliberate-break tamper checks return structured
FAIL_BROKENJSON when underlying git inspection fails (CalledProcessError), with an added regression test. - Tighten benchmark policy validation by rejecting non-dict (including falsy)
minimum_cases_per_category_overridesvalues instead of silently defaulting. - Align
coverageto7.15.3across canonical pins/locks and the consumer + integration templates, and carry theneeds_attentionboolean parsing fix into the consumer template.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tools/evaluate_model_benchmark.py | Stops silently defaulting invalid override types; enforces dict-or-None for overrides. |
| tests/tools/test_evaluate_model_benchmark.py | Expands coverage for invalid override values via parametrized test. |
| scripts/check_deliberate_break.py | Returns structured FAIL_BROKEN result when git tamper inspection errors (e.g., bad revision). |
| tests/scripts/test_check_deliberate_break.py | Adds regression test asserting structured output for tamper git failures. |
| templates/consumer-repo/scripts/check_deliberate_break.py | Mirrors deliberate-break tamper failure handling into the consumer template. |
| templates/consumer-repo/.github/scripts/verifier_verdict_json.py | Fixes needs_attention handling to respect explicit booleans (and avoid truthiness coercion). |
| .github/workflows/autofix-versions.env | Bumps Coverage pin to 7.15.3 for canonical workflow tooling. |
| templates/consumer-repo/.github/workflows/autofix-versions.env | Mirrors Coverage pin bump into consumer template. |
| templates/integration-repo/.github/workflows/autofix-versions.env | Mirrors Coverage pin bump into integration template. |
| pyproject.toml | Bumps dev dependency pin for Coverage to 7.15.3. |
| requirements.lock | Updates locked Coverage version to 7.15.3. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@templates/consumer-repo/.github/workflows/autofix-versions.env`:
- Line 15: Remove the shared COVERAGE_VERSION update from the consumer
template’s autofix-versions.env, preserving the repository-specific value. Do
not modify synchronization manifests, guidance, or scripts unless intentionally
changing the exclusion contract.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 3b8294d6-f14c-40c6-8cb5-a3ede4fe70bd
⛔ Files ignored due to path filters (1)
requirements.lockis excluded by!**/*.lock,!**/*.lock
📒 Files selected for processing (10)
.github/workflows/autofix-versions.envpyproject.tomlscripts/check_deliberate_break.pytemplates/consumer-repo/.github/scripts/verifier_verdict_json.pytemplates/consumer-repo/.github/workflows/autofix-versions.envtemplates/consumer-repo/scripts/check_deliberate_break.pytemplates/integration-repo/.github/workflows/autofix-versions.envtests/scripts/test_check_deliberate_break.pytests/tools/test_evaluate_model_benchmark.pytools/evaluate_model_benchmark.py
stranske
enabled auto-merge (squash)
August 4, 2026 02:48
Contributor
Automated Status SummaryHead SHA: 2aed616
Coverage Overview
Coverage Trend
Top Coverage Hotspots (lowest coverage)
Low Coverage Files (<50.0%)
Updated automatically; will refresh on subsequent CI/Docker completions. Keepalive checklistScopeNo scope information available Tasks
Acceptance criteria
|
This was referenced Aug 4, 2026
This was referenced Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VERDICT_BROKENoutput when deliberate-break tamper Git inspection failsQueue impact
This is the source-first repair for Manager-Database #1515 and Counter_Risk #904, and removes the pin conflict blocking Workflows-Integration-Tests #51. After merge, regenerate consumer sync/dev-tool PRs and supersede the stale affected branches.
Validation
python3 -m pytest -q tests/scripts/test_check_deliberate_break.py tests/tools/test_evaluate_model_benchmark.py tests/workflows/test_verifier_verdict_parsing.py tests/workflows/test_verifier_terminal_disposition.py(50 passed)ruff checkon changed Python filespython3 scripts/validate_template_completeness.pySummary by CodeRabbit
Bug Fixes
Tests
Chores