Skip to content

chore: sync workflow templates - #1515

Closed
stranske wants to merge 1 commit into
mainfrom
sync/workflows-402088f18625
Closed

chore: sync workflow templates#1515
stranske wants to merge 1 commit into
mainfrom
sync/workflows-402088f18625

Conversation

@stranske

@stranske stranske commented Aug 3, 2026

Copy link
Copy Markdown
Owner

Sync Summary

Files Updated

  • check_deliberate_break.py: Opt-in Gate helper that proves named deliberate-break acceptance tests fail against the base implementation
  • registry.yml: Agent registry - source of truth for agent keys and runner workflow mapping
  • pr_verifier.py: PR verifier - validates PR changes against acceptance criteria
  • WORKFLOW_USER_GUIDE.md: Workflow user guide - explains the CI/agent system for repo consumers

Files Skipped

  • .github/workflows/pr-00-gate.yml: Maintains a fully custom Gate workflow; never overwrite (replaces the hard-coded custom_gate_repos list in maint-68).
  • ci.yml: File exists and sync_mode is create_only
  • renovate.json: File exists and sync_mode is create_only
  • cross-repo-smoke.yml: File exists and sync_mode is create_only
  • llm_slots.json: None

Review Checklist

  • CI passes with updated workflows
  • No repo-specific customizations were overwritten

Source: stranske/Workflows
Source SHA: cbd86733a4ff0142bd66364176ee99b17a7ed122
Template hash: 402088f18625
Consumer-sync plan ID: sha256:402088f18625fa53fae99052f7025f1d30100df55f0b89df1122c48e96d246c8
Sync phase: canary
Sync branch: sync/workflows-402088f18625
Consumer repo: stranske/Manager-Database
Manifest: .github/sync-manifest.yml

  Automated sync from stranske/Workflows
  Template hash: 402088f18625

  Changes synced from sync-manifest.yml
Copilot AI review requested due to automatic review settings August 3, 2026 06:01
@stranske stranske added sync Automated sync from Workflows automated Automated sync from Workflows labels Aug 3, 2026
@cursor

cursor Bot commented Aug 3, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (7)
  • sync
  • workflow:source-sync
  • workflow:source-maintenance
  • consumer-sync
  • integration-sync
  • workflows-sync
  • template-sync

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: e46fab09-2803-47f1-abc7-3f46da00cac1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Not ready to approve

scripts/check_deliberate_break.py can still crash during the tamper-check path on git CalledProcessError, preventing a structured JSON verdict from being emitted.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.

Pull request overview

Syncs consumer workflow template content from stranske/Workflows, updating the agent registry, verifier robustness, and consumer-facing documentation to reflect the newer central-workflow model.

Changes:

  • Harden pr_verifier.py structured-output parsing to handle non-string provider payloads (e.g., block lists) and make schema-repair responses stricter.
  • Extend check_deliberate_break.py to optionally install minimal pytest runtime deps (PyYAML) and improve failure reporting for timeouts / install failures.
  • Update WORKFLOW_USER_GUIDE.md to clarify which maintenance workflows are central-only, and bump the default Codex model selection in .github/agents/registry.yml.
File summaries
File Description
WORKFLOW_USER_GUIDE.md Updates workflow documentation to distinguish central-only maintenance workflows from consumer templates.
scripts/langchain/pr_verifier.py Makes LLM response parsing resilient to provider “content” shapes and avoids wasting repair attempts on metadata-only replies.
scripts/check_deliberate_break.py Adds runtime dependency installation (PyYAML) and additional error-to-JSON handling for deliberate-break Gate checks.
.github/agents/registry.yml Updates the default Codex execution profile model/fallback to the latest synced registry values.
Review details
  • Files reviewed: 4/4 changed files
  • Comments generated: 1
  • Review effort level: Lite

We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.

Comment on lines +275 to +279
except subprocess.TimeoutExpired as exc:
return _json_result(
VERDICT_BROKEN,
reason="command-timeout",
command=list(exc.cmd) if isinstance(exc.cmd, (tuple, list)) else str(exc.cmd),
@stranske

stranske commented Aug 4, 2026

Copy link
Copy Markdown
Owner Author

Superseded by the newer sync generation in #1516. The actionable tamper-check review finding is being repaired at the Workflows source in stranske/Workflows#2908; the post-merge sync will replace #1516 as needed.

@stranske stranske closed this Aug 4, 2026
@stranske
stranske deleted the sync/workflows-402088f18625 branch August 6, 2026 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated Automated sync from Workflows sync Automated sync from Workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants