fix: expand bot_authors default to include all known bot types #249
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -31,10 +31,10 @@ on: | |||||
| type: boolean | ||||||
| default: false | ||||||
| bot_authors: | ||||||
| description: 'Comma-separated list of bot login names (default includes Copilot, github-actions, coderabbitai, chatgpt-codex-connector)' | ||||||
| required: false | ||||||
| type: string | ||||||
| default: 'Copilot,copilot[bot],github-actions[bot],coderabbitai[bot],chatgpt-codex-connector[bot]' | ||||||
|
There was a problem hiding this comment. Inconsistent naming convention: "Copilot" (without [bot] suffix) is included alongside "copilot[bot]". GitHub bot usernames typically use the [bot] suffix format. If "Copilot" is a valid bot username, including both variants may cause duplicate matching (though the case-insensitive comparison at line 173 would treat them as the same). Consider removing "Copilot" and keeping only "copilot[bot]" for consistency with the other bot names in the list, or verify if "Copilot" is a distinct bot username that needs to be included separately.
Suggested change
Comment on lines
+34
to
+37
There was a problem hiding this comment.
The new default value for Useful? React with 👍 / 👎. |
||||||
| skip_if_human_replied: | ||||||
| description: 'Skip comments where a human has already replied' | ||||||
| required: false | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description should clarify that the [bot] suffix is required for most bot login names (except where explicitly different). The current description states "default includes Copilot, github-actions, coderabbitai, chatgpt-codex-connector" but the actual default values include the [bot] suffix for most entries. This could be misleading for users who want to customize the bot_authors parameter.