Skip to content

fix: expand bot_authors default to include all known bot types#249

Merged
stranske merged 1 commit intomainfrom
fix/bot-authors-default
Dec 28, 2025
Merged

fix: expand bot_authors default to include all known bot types#249
stranske merged 1 commit intomainfrom
fix/bot-authors-default

Conversation

@stranske
Copy link
Copy Markdown
Owner

Added Copilot and chatgpt-codex-connector[bot] to the default list of bot authors to process.

Added:
- Copilot (GitHub Copilot code review uses this login)
- chatgpt-codex-connector[bot] (Codex review comments)
Copilot AI review requested due to automatic review settings December 28, 2025 04:59
@agents-workflows-bot
Copy link
Copy Markdown
Contributor

⚠️ Action Required: Unable to determine source issue for PR #249. The PR title, branch name, or body must contain the issue number (e.g. #123, branch: issue-123, or the hidden marker ).

@github-actions
Copy link
Copy Markdown
Contributor

Automated Status Summary

Head SHA: b3d1c9c
Latest Runs: ⏳ pending — Gate
Required contexts: Gate / gate, Health 45 Agents Guard / Enforce agents workflow protections
Required: core tests (3.11): ⏳ pending, core tests (3.12): ⏳ pending, docker smoke: ⏳ pending, gate: ⏳ pending

Workflow / Job Result Logs
(no jobs reported) ⏳ pending

Coverage Overview

  • Coverage history entries: 1

Coverage Trend

Metric Value
Current 78.63%
Baseline 0.00%
Delta +78.63%
Minimum 70.00%
Status ✅ Pass

Updated automatically; will refresh on subsequent CI/Docker completions.


Keepalive checklist

Scope

No scope information available

Tasks

  • No tasks defined

Acceptance criteria

  • No acceptance criteria defined

@stranske stranske merged commit 4325c86 into main Dec 28, 2025
42 checks passed
@stranske stranske deleted the fix/bot-authors-default branch December 28, 2025 05:01
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR expands the default list of bot authors that the bot comment handler workflow processes. The change adds two new bot types (Copilot and chatgpt-codex-connector) to handle comments from a broader range of automated code review tools.

Key Changes:

  • Expanded bot_authors default parameter to include "Copilot" and "chatgpt-codex-connector[bot]"
  • Updated parameter description to reflect the expanded bot types

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

required: false
type: string
default: 'copilot[bot],github-actions[bot],coderabbitai[bot]'
default: 'Copilot,copilot[bot],github-actions[bot],coderabbitai[bot],chatgpt-codex-connector[bot]'
Copy link

Copilot AI Dec 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent naming convention: "Copilot" (without [bot] suffix) is included alongside "copilot[bot]". GitHub bot usernames typically use the [bot] suffix format. If "Copilot" is a valid bot username, including both variants may cause duplicate matching (though the case-insensitive comparison at line 173 would treat them as the same). Consider removing "Copilot" and keeping only "copilot[bot]" for consistency with the other bot names in the list, or verify if "Copilot" is a distinct bot username that needs to be included separately.

Suggested change
default: 'Copilot,copilot[bot],github-actions[bot],coderabbitai[bot],chatgpt-codex-connector[bot]'
default: 'copilot[bot],github-actions[bot],coderabbitai[bot],chatgpt-codex-connector[bot]'

Copilot uses AI. Check for mistakes.
default: false
bot_authors:
description: 'Comma-separated list of bot login names including [bot] suffix (default: copilot[bot],github-actions[bot],coderabbitai[bot])'
description: 'Comma-separated list of bot login names (default includes Copilot, github-actions, coderabbitai, chatgpt-codex-connector)'
Copy link

Copilot AI Dec 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description should clarify that the [bot] suffix is required for most bot login names (except where explicitly different). The current description states "default includes Copilot, github-actions, coderabbitai, chatgpt-codex-connector" but the actual default values include the [bot] suffix for most entries. This could be misleading for users who want to customize the bot_authors parameter.

Suggested change
description: 'Comma-separated list of bot login names (default includes Copilot, github-actions, coderabbitai, chatgpt-codex-connector)'
description: 'Comma-separated list of bot login names. Default: Copilot,copilot[bot],github-actions[bot],coderabbitai[bot],chatgpt-codex-connector[bot]. Note: most GitHub bot logins use the [bot] suffix.'

Copilot uses AI. Check for mistakes.
@github-actions
Copy link
Copy Markdown
Contributor

🤖 Keepalive Loop Status

PR #249 | Agent: Codex | Iteration 0/5

Current State

Metric Value
Iteration progress [----------] 0/5
Action wait (missing-agent-label)
Gate success
Tasks 0/0 complete
Keepalive ❌ disabled
Autofix ❌ disabled

🔍 Failure Classification

| Error type | infrastructure |
| Error category | resource |
| Suggested recovery | Confirm the referenced resource exists (repo, PR, branch, workflow, or file). |

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +34 to +37
description: 'Comma-separated list of bot login names (default includes Copilot, github-actions, coderabbitai, chatgpt-codex-connector)'
required: false
type: string
default: 'copilot[bot],github-actions[bot],coderabbitai[bot]'
default: 'Copilot,copilot[bot],github-actions[bot],coderabbitai[bot],chatgpt-codex-connector[bot]'
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Default bot list misses chatgpt-codex-connector

The new default value for bot_authors adds chatgpt-codex-connector[bot], but the collector does a case-insensitive exact login match without stripping the [bot] suffix. Our fixtures and keepalive tooling model the Codex connector user as chatgpt-codex-connector (e.g., tests/workflows/fixtures/keepalive/gate_trigger.json), so with the default input the workflow will still skip that bot’s review comments and never trigger the handler unless consumers override the list. Please include the actual login (chatgpt-codex-connector) in the default set.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants