fix: expand bot_authors default to include all known bot types#249
fix: expand bot_authors default to include all known bot types#249
Conversation
Added: - Copilot (GitHub Copilot code review uses this login) - chatgpt-codex-connector[bot] (Codex review comments)
Automated Status SummaryHead SHA: b3d1c9c
Coverage Overview
Coverage Trend
Updated automatically; will refresh on subsequent CI/Docker completions. Keepalive checklistScopeNo scope information available Tasks
Acceptance criteria
|
There was a problem hiding this comment.
Pull request overview
This PR expands the default list of bot authors that the bot comment handler workflow processes. The change adds two new bot types (Copilot and chatgpt-codex-connector) to handle comments from a broader range of automated code review tools.
Key Changes:
- Expanded
bot_authorsdefault parameter to include "Copilot" and "chatgpt-codex-connector[bot]" - Updated parameter description to reflect the expanded bot types
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| required: false | ||
| type: string | ||
| default: 'copilot[bot],github-actions[bot],coderabbitai[bot]' | ||
| default: 'Copilot,copilot[bot],github-actions[bot],coderabbitai[bot],chatgpt-codex-connector[bot]' |
There was a problem hiding this comment.
Inconsistent naming convention: "Copilot" (without [bot] suffix) is included alongside "copilot[bot]". GitHub bot usernames typically use the [bot] suffix format. If "Copilot" is a valid bot username, including both variants may cause duplicate matching (though the case-insensitive comparison at line 173 would treat them as the same). Consider removing "Copilot" and keeping only "copilot[bot]" for consistency with the other bot names in the list, or verify if "Copilot" is a distinct bot username that needs to be included separately.
| default: 'Copilot,copilot[bot],github-actions[bot],coderabbitai[bot],chatgpt-codex-connector[bot]' | |
| default: 'copilot[bot],github-actions[bot],coderabbitai[bot],chatgpt-codex-connector[bot]' |
| default: false | ||
| bot_authors: | ||
| description: 'Comma-separated list of bot login names including [bot] suffix (default: copilot[bot],github-actions[bot],coderabbitai[bot])' | ||
| description: 'Comma-separated list of bot login names (default includes Copilot, github-actions, coderabbitai, chatgpt-codex-connector)' |
There was a problem hiding this comment.
The description should clarify that the [bot] suffix is required for most bot login names (except where explicitly different). The current description states "default includes Copilot, github-actions, coderabbitai, chatgpt-codex-connector" but the actual default values include the [bot] suffix for most entries. This could be misleading for users who want to customize the bot_authors parameter.
| description: 'Comma-separated list of bot login names (default includes Copilot, github-actions, coderabbitai, chatgpt-codex-connector)' | |
| description: 'Comma-separated list of bot login names. Default: Copilot,copilot[bot],github-actions[bot],coderabbitai[bot],chatgpt-codex-connector[bot]. Note: most GitHub bot logins use the [bot] suffix.' |
🤖 Keepalive Loop StatusPR #249 | Agent: Codex | Iteration 0/5 Current State
🔍 Failure Classification| Error type | infrastructure | |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| description: 'Comma-separated list of bot login names (default includes Copilot, github-actions, coderabbitai, chatgpt-codex-connector)' | ||
| required: false | ||
| type: string | ||
| default: 'copilot[bot],github-actions[bot],coderabbitai[bot]' | ||
| default: 'Copilot,copilot[bot],github-actions[bot],coderabbitai[bot],chatgpt-codex-connector[bot]' |
There was a problem hiding this comment.
Default bot list misses chatgpt-codex-connector
The new default value for bot_authors adds chatgpt-codex-connector[bot], but the collector does a case-insensitive exact login match without stripping the [bot] suffix. Our fixtures and keepalive tooling model the Codex connector user as chatgpt-codex-connector (e.g., tests/workflows/fixtures/keepalive/gate_trigger.json), so with the default input the workflow will still skip that bot’s review comments and never trigger the handler unless consumers override the list. Please include the actual login (chatgpt-codex-connector) in the default set.
Useful? React with 👍 / 👎.
Added Copilot and chatgpt-codex-connector[bot] to the default list of bot authors to process.