Skip to content

chore: install build tools before app dependency setup#606

Merged
stranske merged 1 commit intophase-2-devfrom
codex/fix-dockerfile-package-installation-issues
Sep 2, 2025
Merged

chore: install build tools before app dependency setup#606
stranske merged 1 commit intophase-2-devfrom
codex/fix-dockerfile-package-installation-issues

Conversation

@stranske
Copy link
Copy Markdown
Owner

@stranske stranske commented Sep 2, 2025

Summary

  • install pip, setuptools, and wheel before installing project deps in Dockerfile
  • ensures editable install of [app] extras works during image build

Testing

  • ⚠️ ./scripts/run_streamlit.sh --help (bootstrap cancelled)
  • pytest -q (6 failed, 444 passed)

https://chatgpt.com/codex/tasks/task_e_68b66d27c8808331bbd77fd94ae61a7b

Copilot AI review requested due to automatic review settings September 2, 2025 04:10
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the Dockerfile to install essential build tools (pip, setuptools, wheel) in a separate step before installing project dependencies, ensuring that editable installs work correctly during the Docker image build process.

Key Changes

  • Separates build tool installation from dependency installation for better reliability
  • Removes redundant pip upgrade from the dependency installation step
Comments suppressed due to low confidence (1)

Dockerfile:1

  • The timeout and retries options are not applied to the build tools installation on line 15. For consistency and reliability, these options should also be used when installing pip, setuptools, and wheel to handle potential network issues during the build tool installation step.
FROM python:3.11-slim

@stranske stranske merged commit 6395ce3 into phase-2-dev Sep 2, 2025
0 of 3 checks passed
@stranske stranske deleted the codex/fix-dockerfile-package-installation-issues branch September 2, 2025 04:13
stranske added a commit that referenced this pull request Jan 7, 2026
Root cause: The workflow was using mode: 'invite' without force_mode,
causing the reusable workflow to ignore the mode and prevent automatic
bootstrap PR creation when issues are labeled with agent:codex.

Changes:
- Change mode from 'invite' to 'create' in bridge job
- Add force_mode: true to override issue event defaults

This matches the fix from Workflows repo commit bd48949 (PR #606) which
resolved the same startup_failure issue in other consumer repos.

Fixes #4185
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants