fix(keepalive): resume nudges after stale commands#2899
Merged
stranske merged 4 commits intophase-2-devfrom Oct 21, 2025
Merged
fix(keepalive): resume nudges after stale commands#2899stranske merged 4 commits intophase-2-devfrom
stranske merged 4 commits intophase-2-devfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the keepalive workflow to resume nudging pull requests after command response timeouts. The key change is adding a time-based threshold so that if an agent hasn't responded to a command within the idle timeout period, keepalive comments will resume.
Key changes:
- Added time-based logic to resume keepalive nudges when commands become stale (exceed idle timeout)
- Created new test scenario validating the stale command handling behavior
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
scripts/keepalive-runner.js |
Added time threshold check to resume keepalive after stale commands |
tests/test_keepalive_workflow.py |
Added test for command timeout scenario with formatting fixes |
tests/fixtures/keepalive/command_pending.json |
New fixture with two PRs testing recent vs stale command timing |
Owner
Author
|
@codex fix comments |
|
Summary
Testing
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
CI readiness
gateis the required status and Maint 46 Post CI is informational after merge.gateappears under Required checks (Health 45 Agents Guard auto-adds whenagents-*.ymlfiles change).gateis missing or Maint 46 Post CI shows up as required.