Skip to content

fix(keepalive): resume nudges after stale commands#2899

Merged
stranske merged 4 commits intophase-2-devfrom
chore/keepalive-instructions-fix
Oct 21, 2025
Merged

fix(keepalive): resume nudges after stale commands#2899
stranske merged 4 commits intophase-2-devfrom
chore/keepalive-instructions-fix

Conversation

@stranske
Copy link
Copy Markdown
Owner

Summary

  • Provide a concise description of the change.
  • Note any follow-up tasks or docs to update later.

Testing

  • Listed the commands or scripts used to validate the change.
  • Attached or linked relevant logs when tests are not applicable.

CI readiness

  • Skimmed the workflow spotlight for Gate, Maint 46, Repo Health, Actionlint, Agents Orchestrator, and Health 45 Agents Guard when touching automation.
  • Reviewed the Workflow System Overview to confirm Gate / gate is the required status and Maint 46 Post CI is informational after merge.
  • Checked this pull request's Checks tab to confirm Gate / gate appears under Required checks (Health 45 Agents Guard auto-adds when agents-*.yml files change).
  • Escalated via the branch protection playbook if Gate / gate is missing or Maint 46 Post CI shows up as required.
  • Confirmed the latest Gate run is green (or linked the failing run with context).

Copilot AI review requested due to automatic review settings October 21, 2025 06:38
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the keepalive workflow to resume nudging pull requests after command response timeouts. The key change is adding a time-based threshold so that if an agent hasn't responded to a command within the idle timeout period, keepalive comments will resume.

Key changes:

  • Added time-based logic to resume keepalive nudges when commands become stale (exceed idle timeout)
  • Created new test scenario validating the stale command handling behavior

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
scripts/keepalive-runner.js Added time threshold check to resume keepalive after stale commands
tests/test_keepalive_workflow.py Added test for command timeout scenario with formatting fixes
tests/fixtures/keepalive/command_pending.json New fixture with two PRs testing recent vs stale command timing

@stranske
Copy link
Copy Markdown
Owner Author

@codex fix comments

@chatgpt-codex-connector
Copy link
Copy Markdown

Summary

Testing

  • pytest tests/test_keepalive_workflow.py::test_keepalive_waits_for_recent_command

View task →

@stranske stranske merged commit 0a22693 into phase-2-dev Oct 21, 2025
11 checks passed
@stranske stranske deleted the chore/keepalive-instructions-fix branch October 21, 2025 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants