Skip to content

chore: sync workflow templates - #614

Closed
stranske wants to merge 1 commit into
mainfrom
sync/workflows-e8a3a32a3996
Closed

chore: sync workflow templates#614
stranske wants to merge 1 commit into
mainfrom
sync/workflows-e8a3a32a3996

Conversation

@stranske

Copy link
Copy Markdown
Owner

Sync Summary

Files Updated

  • agents-81-gate-followups.yml: Gate followups hub - consolidates keepalive and autofix followups
  • agents-bot-comment-handler.yml: Bot comment handler - dispatches agents to address bot review comments (deprecated; replaced by agents-80-pr-event-hub.yml, removal no earlier than 2026-02-15)
  • agents-verify-to-new-pr.yml: Verify to new PR - creates follow-up issue and immediately dispatches auto-pilot to prepare a replacement PR (bridge inlined)
  • agents-weekly-metrics.yml: Weekly metrics - aggregates auto-pilot, keepalive, autofix and verifier metrics into summary reports
  • aggregate_agent_metrics.py: Aggregates downloaded weekly agent metrics - required by agents-weekly-metrics.yml
  • terminal_disposition.js: Machine-readable terminal disposition records and source summaries
  • terminal_disposition_coverage.js: Warning-only terminal disposition source coverage preflight
  • bot_comment_auth_coverage.js: Warning-only bot-comment App auth coverage preflight
  • coverage_monitor_summary.js: Machine-readable weekly coverage monitor checkpoint
  • weekly_metrics_artifacts.js: Bounded weekly metrics artifact selection contract
  • weekly_metrics_download_manifest.js: Weekly metrics artifact download and extraction manifest contract
  • keepalive_loop.js: Core keepalive loop logic
  • agents_pr_meta_update_body.js: Updates PR body with agent metadata
  • setup-api-client/ (1 files): Unified API client setup - installs @octokit deps and exports all load balancer tokens

Files Skipped

  • pr-00-gate.yml: File exists and sync_mode is create_only
  • ci.yml: File exists and sync_mode is create_only
  • dependabot.yml: File exists and sync_mode is create_only
  • llm_slots.json: None

Review Checklist

  • CI passes with updated workflows
  • No repo-specific customizations were overwritten

Source: stranske/Workflows
Manifest: .github/sync-manifest.yml

Automated sync from stranske/Workflows
Template hash: e8a3a32a3996

Changes synced from sync-manifest.yml
@stranske stranske added sync Automated sync from Workflows automated Automated sync from Workflows labels Apr 26, 2026
Copilot AI review requested due to automatic review settings April 26, 2026 16:05
@stranske stranske added sync Automated sync from Workflows automated Automated sync from Workflows labels Apr 26, 2026
@stranske-keepalive

Copy link
Copy Markdown
Contributor

⚠️ Action Required: Unable to determine source issue for PR #614. The PR title, branch name, or body must contain the issue number (e.g. #123, branch: issue-123, or the hidden marker ).

@stranske-keepalive

stranske-keepalive Bot commented Apr 26, 2026

Copy link
Copy Markdown
Contributor

🤖 Keepalive Loop Status

PR #614 | Agent: Codex | Iteration 0/5

Current State

Metric Value
Iteration progress [----------] 0/5
Action wait (missing-agent-label)
Disposition skipped (transient)
Gate success
Tasks 0/18 complete
Timeout 45 min (default)
Timeout usage 5m elapsed (12%, 40m remaining)
Keepalive ❌ disabled
Autofix ❌ disabled

🔍 Failure Classification

| Error type | infrastructure |
| Error category | resource |
| Suggested recovery | Confirm the referenced resource exists (repo, PR, branch, workflow, or file). |

@stranske-keepalive

stranske-keepalive Bot commented Apr 26, 2026

Copy link
Copy Markdown
Contributor
Keepalive Work Log (click to expand)
# Time (UTC) Agent Action Result Files Tasks Progress Commit Gate
0 2026-04-26 16:07:23 Codex wait (missing-agent-label-transient) skipped 0 0/18 cancelled
0 2026-04-26 16:10:24 Codex wait (missing-agent-label-transient) skipped 0 0/18 cancelled
0 2026-04-26 16:11:15 Codex wait (missing-agent-label-transient) skipped 0 0/18 success

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Syncs workflow templates from stranske/Workflows, expanding weekly metrics collection/telemetry and adding richer machine-readable contracts for downstream monitoring.

Changes:

  • Extend weekly metrics artifact selection + add an explicit artifact download manifest (JSON + markdown) and publish a new aggregated JSON contract.
  • Add verifier follow-up ledger telemetry and enrich terminal-disposition coverage with verifier model compatibility checks.
  • Improve keepalive task counting by filtering out status/placeholder checklist items; enhance PR body preamble behavior for campaign issues.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
scripts/aggregate_agent_metrics.py Adds artifact/source attribution, parse error detail reporting, verifier follow-up ledger summarization, and emits a JSON summary contract (plus optional artifact download manifest ingestion).
.github/workflows/agents-weekly-metrics.yml Generates and updates an artifact download manifest while downloading/unzipping metrics, and uploads the new JSON summary artifact.
.github/workflows/agents-verify-to-new-pr.yml Adds verifier follow-up ledger NDJSON emission and uploads it alongside terminal disposition artifacts; updates agent selection defaults.
.github/workflows/agents-bot-comment-handler.yml Adds skip reason outputs and writes/uploads a wrapper terminal disposition record for observability.
.github/workflows/agents-81-gate-followups.yml Uses compact JSON output for gate follow-up metrics (jq -cn).
.github/scripts/weekly_metrics_download_manifest.js New script to initialize/record/finalize a machine-readable artifact download/unzip manifest and optional markdown summary.
.github/scripts/weekly_metrics_artifacts.js Enhances selection report with priority family status metadata and latest-candidate details.
.github/scripts/terminal_disposition_coverage.js Adds verifier model compatibility checks and richer artifact-selection normalization/markdown reporting.
.github/scripts/terminal_disposition.js Adds verifier follow-up ledger/policy normalization helpers and enriches terminal disposition records with model metadata fields.
.github/scripts/keepalive_loop.js Filters non-actionable checklist items from task/acceptance counting and related summary logic.
.github/scripts/coverage_monitor_summary.js New script emitting a weekly “coverage monitor” summary contract (JSON + markdown).
.github/scripts/bot_comment_auth_coverage.js Tracks wrapper decisions about whether reusable invocation was expected; surfaces skipped/missing organic requirements in the report/markdown.
.github/scripts/agents_pr_meta_update_body.js Adjusts PR preamble to use campaign-aware “Related to …” vs “Closes …” and adds a hidden meta issue marker.
.github/actions/setup-api-client/action.yml Adds a redacted “setup contract” output describing token/auth/dependency state for diagnostics.

Comment on lines 33 to 37
- name: Check PR is merged
id: check-merged
uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9
uses: actions/github-script@v9
with:
github-token: ${{ github.token }}

Copilot AI Apr 26, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow switches several GitHub Actions from commit-SHA pinning to mutable version tags (e.g., actions/github-script@v9). Most agents-* workflows in this repo pin these actions to a specific commit (for supply-chain safety and reproducibility), e.g. .github/workflows/agents-weekly-metrics.yml uses actions/github-script@3a2844b7.... Consider reverting to the prior commit-SHA pin (or updating to a specific SHA for v9) instead of the tag.

Copilot uses AI. Check for mistakes.
- name: Checkout repository
if: steps.check-merged.outputs.merged == 'true'
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
uses: actions/checkout@v6

Copilot AI Apr 26, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step changes actions/checkout from a commit-SHA pin to the mutable @v6 tag. In this repo’s agents-* workflows, actions/checkout is typically pinned (e.g. .github/workflows/agents-weekly-metrics.yml uses actions/checkout@de0fac2e...). Using a tag weakens supply-chain protections and can introduce non-reproducible runs; prefer pinning to a specific commit SHA.

Suggested change
uses: actions/checkout@v6
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332

Copilot uses AI. Check for mistakes.
- name: Set up Python
if: steps.check-merged.outputs.merged == 'true'
uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6
uses: actions/setup-python@v6

Copilot AI Apr 26, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step switches actions/setup-python from a commit-SHA pin to the mutable @v6 tag. For consistency with other agents-* workflows and to avoid supply-chain/reproducibility risk, pin actions/setup-python to a specific commit SHA (as done elsewhere in the repo, e.g. .github/workflows/agents-weekly-metrics.yml).

Suggested change
uses: actions/setup-python@v6
uses: actions/setup-python@42375524f58b9b19dbda3c6bfe40cb79e2b1ba88

Copilot uses AI. Check for mistakes.
Comment on lines 1007 to +1014
- name: Upload terminal disposition artifact
if: always() && steps.check-merged.outputs.merged == 'true'
uses: actions/upload-artifact@65ecb0ca2d3e252f7b82842cd0489c883189f7d0 # v7
uses: actions/upload-artifact@v7
with:
name: verifier-terminal-disposition-${{ github.run_id }}
path: |
agent-metrics/verifier-terminal-disposition.ndjson
agent-metrics/verifier-followup-ledger.ndjson

Copilot AI Apr 26, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step switches actions/upload-artifact from a commit-SHA pin to the mutable @v7 tag. To match the pinning approach used throughout the agents-* workflows (and to reduce supply-chain risk), pin to the specific commit SHA for the intended v7 release.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated Automated sync from Workflows sync Automated sync from Workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants