chore: sync workflow templates #126
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -6,23 +6,22 @@ | |||||
| python scripts/langchain/issue_optimizer.py --input-file issue.md --json | ||||||
| """ | ||||||
|
|
||||||
| from __future__ import annotations | ||||||
|
|
||||||
| import argparse | ||||||
| import json | ||||||
| import re | ||||||
| import sys | ||||||
| from dataclasses import dataclass | ||||||
| from pathlib import Path | ||||||
| from typing import Any | ||||||
|
|
||||||
| from pydantic import BaseModel, ConfigDict, Field | ||||||
|
There was a problem hiding this comment. According to PEP 8 import conventions, there should be a blank line between third-party imports (pydantic) and first-party imports (scripts). Removing this blank line violates PEP 8 import grouping standards. The ruff configuration in pyproject.toml includes isort (line 82: "I") which enforces these conventions and would likely flag this as an issue.
Suggested change
|
||||||
| from scripts.langchain.structured_output import ( | ||||||
| DEFAULT_REPAIR_PROMPT, | ||||||
| build_repair_callback, | ||||||
| parse_structured_output, | ||||||
| ) | ||||||
|
Check failure on line 24 in scripts/langchain/issue_optimizer.py
|
||||||
|
|
||||||
| try: | ||||||
| from scripts.langchain.injection_guard import check_prompt_injection | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -6,25 +6,24 @@ | |||||
| python scripts/langchain/pr_verifier.py --context-file verifier-context.md --json | ||||||
| """ | ||||||
|
|
||||||
| from __future__ import annotations | ||||||
|
|
||||||
| import argparse | ||||||
| import json | ||||||
| import logging | ||||||
| import os | ||||||
| import re | ||||||
| import sys | ||||||
| from dataclasses import dataclass | ||||||
| from pathlib import Path | ||||||
| from typing import Literal | ||||||
|
|
||||||
| from pydantic import BaseModel, Field | ||||||
|
There was a problem hiding this comment. According to PEP 8 import conventions, there should be a blank line between third-party imports (pydantic) and first-party imports (scripts). Removing this blank line violates PEP 8 import grouping standards. The ruff configuration in pyproject.toml includes isort (line 82: "I") which enforces these conventions and would likely flag this as an issue.
Suggested change
|
||||||
| from scripts import api_client | ||||||
| from scripts.langchain.structured_output import ( | ||||||
| build_repair_callback, | ||||||
| parse_structured_output, | ||||||
| ) | ||||||
|
Check failure on line 26 in scripts/langchain/pr_verifier.py
|
||||||
|
|
||||||
| LOGGER = logging.getLogger(__name__) | ||||||
|
|
||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This refactoring changes the error handling behavior. The original code used getattr with a default of None, which would gracefully handle the case where HumanMessage doesn't exist in the module. The new code directly accesses lc_messages.HumanMessage, which will raise an AttributeError (not caught by the ModuleNotFoundError handler) if HumanMessage doesn't exist. While unlikely in practice since HumanMessage is a core class, this represents a functional change in error handling that deviates from the defensive programming pattern used in the original code.