generated from stranske/Template
-
Notifications
You must be signed in to change notification settings - Fork 0
chore: sync workflow templates #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e8a0b93
chore: sync workflow templates from Workflows repo
github-actions[bot] 37f3f2e
chore(autofix): formatting/lint
github-actions[bot] bb85ed8
chore(codex-autofix): apply updates (PR #126)
github-actions[bot] 4cabac9
chore(codex-autofix): apply updates (PR #126)
github-actions[bot] 8ff6273
chore(codex-autofix): apply updates (PR #126)
github-actions[bot] 993aa7a
chore(codex-autofix): apply updates (PR #126)
github-actions[bot] 171a85f
Fix lockfile pathspec for Black 26.1
stranske 7d6aa1b
Merge main into sync/workflows-15b48e2532ec
stranske File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This refactoring changes the error handling behavior. The original code used getattr with a default of None, which would gracefully handle the case where HumanMessage doesn't exist in the module. The new code directly accesses lc_messages.HumanMessage, which will raise an AttributeError (not caught by the ModuleNotFoundError handler) if HumanMessage doesn't exist. While unlikely in practice since HumanMessage is a core class, this represents a functional change in error handling that deviates from the defensive programming pattern used in the original code.