test: fix two broken main tests - #2982
Merged
chaynabors merged 1 commit intoJun 26, 2026
Merged
Conversation
Both surfaced on the Python 3.14 linux job after a sequence of merges today: 1. test_format_request_maps_3gp_video_formats (from strands-agents#2306) called a non-existent _format_request; the public method is format_request. 2. test_ingests_extracted_facts_through_add (from strands-agents#2859) called the async MemoryManager.init_agent without awaiting it, so the extractor was never wired up and assert_called_once failed.
github-actions
Bot
added
size/xs
area-community
chaynabors
enabled auto-merge (squash)
June 26, 2026 15:19
yonib05
approved these changes
Jun 26, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This was referenced Jul 7, 2026
This was referenced Jul 14, 2026
This was referenced Jul 22, 2026
Merged
This was referenced Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix tests on main.