fix(bedrock): normalize 3gp video format - #2306
Merged
chaynabors merged 1 commit intoJun 26, 2026
Merged
Conversation
he-yufeng
had a problem deploying
to
manual-approval
May 20, 2026 07:53 — with
GitHub Actions
Failure
he-yufeng
had a problem deploying
to
manual-approval
May 20, 2026 07:53 — with
GitHub Actions
Failure
he-yufeng
force-pushed
the
fix/bedrock-3gp-video-format
branch
from
May 20, 2026 19:09
5944452 to
e814ac7
Compare
he-yufeng
had a problem deploying
to
manual-approval
May 20, 2026 19:09 — with
GitHub Actions
Failure
he-yufeng
had a problem deploying
to
manual-approval
May 20, 2026 19:09 — with
GitHub Actions
Failure
he-yufeng
force-pushed
the
fix/bedrock-3gp-video-format
branch
from
May 20, 2026 19:10
e814ac7 to
012dc57
Compare
he-yufeng
had a problem deploying
to
manual-approval
May 20, 2026 19:10 — with
GitHub Actions
Failure
he-yufeng
had a problem deploying
to
manual-approval
May 20, 2026 19:10 — with
GitHub Actions
Failure
he-yufeng
force-pushed
the
fix/bedrock-3gp-video-format
branch
from
May 27, 2026 09:53
012dc57 to
444de41
Compare
Contributor
Author
|
Rebased this onto current main and revalidated the Bedrock model path. Current head is 444de41. Validation from strands-py: uv run pytest tests/strands/models/test_bedrock.py -q --basetemp ...tmp\pytest-2306 -p no:cacheprovider: 169 passed; uv run ruff check src/strands/models/bedrock.py tests/strands/models/test_bedrock.py; python -m py_compile strands-py\src\strands\models\bedrock.py strands-py\tests\strands\models\test_bedrock.py; git diff --check origin/main...HEAD. Note: ruff format --check wants to reformat pre-existing lines in origin/main's bedrock.py as well, so I did not include unrelated formatting churn in this PR. |
he-yufeng
had a problem deploying
to
manual-approval
May 27, 2026 09:53 — with
GitHub Actions
Failure
he-yufeng
had a problem deploying
to
manual-approval
May 27, 2026 09:53 — with
GitHub Actions
Failure
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
chaynabors
approved these changes
Jun 26, 2026
chaynabors
added a commit
to chaynabors/harness-sdk
that referenced
this pull request
Jun 26, 2026
Both surfaced on the Python 3.14 linux job after a sequence of merges today: 1. test_format_request_maps_3gp_video_formats (from strands-agents#2306) called a non-existent _format_request; the public method is format_request. 2. test_ingests_extracted_facts_through_add (from strands-agents#2859) called the async MemoryManager.init_agent without awaiting it, so the extractor was never wired up and assert_called_once failed.
This was referenced Jul 7, 2026
This was referenced Jul 14, 2026
This was referenced Jul 22, 2026
Merged
This was referenced Aug 4, 2026
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Bedrock 3GP part of #2204.
Bedrock expects the video format enum to be
three_gp, while common MIME/extension paths produce3gp,3gpp, or3g2. The SDK currently forwards the value as-is, so a valid 3GP video content block can be rejected by the Bedrock Converse API.This normalizes those aliases when formatting Bedrock video content blocks. Other media-format gaps from #2204 are left out of this PR.
To verify
Ran locally: