Skip to content

simplify trait bounds as Read/Write-BytesExt#2

Closed
zancas wants to merge 1 commit into
str4d:zcash-transaction-primitivesfrom
zancas:simplify_trait_bounds
Closed

simplify trait bounds as Read/Write-BytesExt#2
zancas wants to merge 1 commit into
str4d:zcash-transaction-primitivesfrom
zancas:simplify_trait_bounds

Conversation

@zancas
Copy link
Copy Markdown

@zancas zancas commented Nov 21, 2018

Hiya! I didn't want to to wait for the data movement PR to resolve. I think this one is fairly simple, but I don't know Rust very well, and may be overlooking something.. if my understanding is correct, then this change makes the code a little more readable.

@zancas
Copy link
Copy Markdown
Author

zancas commented Nov 29, 2018

This is superceded by:

#3

@zancas zancas closed this Nov 29, 2018
str4d added a commit that referenced this pull request Jan 6, 2019
CryptoForge referenced this pull request in CryptoForge/librustzcash Mar 3, 2019
Do not perform inversions when converting from montgomery to edwards
CryptoForge referenced this pull request in CryptoForge/librustzcash Mar 3, 2019
Add sapling-crypto to dependencies
str4d pushed a commit that referenced this pull request Jun 18, 2019
str4d pushed a commit that referenced this pull request Mar 4, 2020
str4d pushed a commit that referenced this pull request Jun 4, 2021
…dularization

ZIP-225/244 #2: Refactor transaction builder to create separate builders for each section.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant