Repository navigation
Sandboxes: Remove the SvelteKit 3 age-gate workaround - #36692
Conversation
PR #36610 added a workaround to the svelte-kit/skeleton-ts template. SvelteKit 3 and sv 1.x were younger than the 7-day npm age gate, so the template used --min-release-age=0, minAgeGateExemptions and inDevelopment: true. Both releases are now older than the gate, and the published sandbox has SvelteKit 3. The workaround is no longer necessary. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 120 | 120 | 0 |
| Self size | 29 KB | 29 KB | 0 B |
| Dependency size | 26.06 MB | 26.29 MB | 🚨 +234 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. WalkthroughThe SvelteKit template no longer passes ChangesSvelteKit scaffold
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to The template will honor npm’s configured release-age policy rather than bypassing it. The supplied evidence establishes no specific failure that should block merging. ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Closes #
What I did
Follow-up to #36610. That PR added a temporary workaround to the
svelte-kit/skeleton-tssandbox template. SvelteKit 3 andsv1.x were younger than the 7-day npm age gate.This PR removes the workaround:
--min-release-age=0in thenpx sv@latest createscriptminAgeGateExemptions: ['@sveltejs/kit', '@sveltejs/adapter-auto']inDevelopment: trueTODOcomment that explains themIt is now safe:
storybookjs/sandboxeshas@sveltejs/kit: ^3.0.0.sv@latest(1.0.1) installs withNPM_CONFIG_MIN_RELEASE_AGE=7and no flag.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Caution
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
yarn task sandbox --template svelte-kit/skeleton-ts --start-from auto.../storybook-sandboxes/svelte-kit-skeleton-ts, runnode -p "require('@sveltejs/kit/package.json').version". It must print 3.x.NPM_CONFIG_MIN_RELEASE_AGE=7 npx --yes sv@latest --version. It must print 1.x without an age-gate error.The
ci:dailylabel runs the SvelteKit sandbox in CI.Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsDeclare whether manual QA will be needed for this PR during the next release, through
qa:neededorqa:skipMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary Release - 🚫 Not run
This PR does not have a canary release associated.
In-repo PRs: add the
ci:canarylabel. Later pushes republish while the label remains.Fork PRs: the label does nothing (a later push must not auto-publish). A maintainer publishes from this repository with Run workflow and the
prinput.branchandshaare optional; if more than one is set, they must be the same commit. The fork author does not need to do anything.🤖 Generated with Claude Code