Skip to content

Sandboxes: Remove the SvelteKit 3 age-gate workaround - #36692

Merged
valentinpalkovic merged 1 commit into
nextfrom
jeppe/sveltekit-3-sandbox-cleanup
Oct 15, 2026
Merged

valentinpalkovic merged 1 commit into
nextfrom
jeppe/sveltekit-3-sandbox-cleanup

Conversation

@JReinhold

Copy link
Copy Markdown
Contributor

Closes #

What I did

Follow-up to #36610. That PR added a temporary workaround to the svelte-kit/skeleton-ts sandbox template. SvelteKit 3 and sv 1.x were younger than the 7-day npm age gate.

This PR removes the workaround:

  • --min-release-age=0 in the npx sv@latest create script
  • minAgeGateExemptions: ['@sveltejs/kit', '@sveltejs/adapter-auto']
  • inDevelopment: true
  • the TODO comment that explains them

It is now safe:

  • The published sandbox in storybookjs/sandboxes has @sveltejs/kit: ^3.0.0.
  • sv@latest (1.0.1) installs with NPM_CONFIG_MIN_RELEASE_AGE=7 and no flag.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

Caution

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

  1. Run yarn task sandbox --template svelte-kit/skeleton-ts --start-from auto.
  2. Make sure the log shows "Downloading sandbox template (before-storybook)" and the task completes.
  3. In ../storybook-sandboxes/svelte-kit-skeleton-ts, run node -p "require('@sveltejs/kit/package.json').version". It must print 3.x.
  4. Optional: in an empty directory, run NPM_CONFIG_MIN_RELEASE_AGE=7 npx --yes sv@latest --version. It must print 1.x without an age-gate error.

The ci:daily label runs the SvelteKit sandbox in CI.

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Declare whether manual QA will be needed for this PR during the next release, through qa:needed or qa:skip

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary Release - 🚫 Not run

This PR does not have a canary release associated.

In-repo PRs: add the ci:canary label. Later pushes republish while the label remains.

Fork PRs: the label does nothing (a later push must not auto-publish). A maintainer publishes from this repository with Run workflow and the pr input. branch and sha are optional; if more than one is set, they must be the same commit. The fork author does not need to do anything.

🤖 Generated with Claude Code

PR #36610 added a workaround to the svelte-kit/skeleton-ts template.
SvelteKit 3 and sv 1.x were younger than the 7-day npm age gate, so the
template used --min-release-age=0, minAgeGateExemptions and
inDevelopment: true.

Both releases are now older than the gate, and the published sandbox
has SvelteKit 3. The workaround is no longer necessary.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@JReinhold JReinhold added build Internal-facing build tooling & test updates ci:daily Run the CI jobs that normally run in the daily job. qa:skip Pull Requests that do not need any QA. (e.g. documentation) labels Oct 9, 2026
@JReinhold JReinhold self-assigned this Oct 9, 2026
@storybook-app-bot

Copy link
Copy Markdown
Contributor

Package Benchmarks

Commit: d0f2f3d, ran on 9 October 2026 at 07:13:32 UTC

The following packages have significant changes to their size or dependencies:

@storybook/react-native-web-vite

Before After Difference
Dependency count 120 120 0
Self size 29 KB 29 KB 0 B
Dependency size 26.06 MB 26.29 MB 🚨 +234 KB 🚨
Bundle Size Analyzer Link Link

@JReinhold
JReinhold marked this pull request as ready for review October 9, 2026 07:15
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-09T07:18:34.740676Z d0f2f3d Draft marked ready
🔒 Security Review ✅ Completed 2026-10-09T07:20:07.188001Z d0f2f3d Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@JReinhold
JReinhold requested a review from ghengeveld October 9, 2026 07:15
@coderabbitai

coderabbitai Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b110db5d-1b1a-4fd6-8902-4a0aa8901880
📥 Commits

Reviewing files that changed from the base of the PR and between 73de94c and d0f2f3d.

📒 Files selected for processing (1)
  • code/lib/cli-storybook/src/sandbox-templates.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.


Walkthrough

The SvelteKit template no longer passes --min-release-age=0. Its minAgeGateExemptions and inDevelopment settings were removed.

Changes

SvelteKit scaffold

Layer / File(s) Summary
Update SvelteKit scaffold settings
code/lib/cli-storybook/src/sandbox-templates.ts
The scaffold command no longer passes --min-release-age=0. The template’s minAgeGateExemptions and inDevelopment settings were removed.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to d0f2f

The template will honor npm’s configured release-age policy rather than bypassing it. The supplied evidence establishes no specific failure that should block merging.

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@valentinpalkovic
valentinpalkovic merged commit 4cdd3bd into next Oct 15, 2026
289 of 298 checks passed
@valentinpalkovic
valentinpalkovic deleted the jeppe/sveltekit-3-sandbox-cleanup branch October 15, 2026 13:11
@github-actions github-actions Bot mentioned this pull request Oct 15, 2026
2 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates ci:daily Run the CI jobs that normally run in the daily job. qa:skip Pull Requests that do not need any QA. (e.g. documentation)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants