Skip to content

TanstackReact: Fix accross typo in path-utils comment #36634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
valentinpalkovic merged 2 commits into from
Oct 20, 2026
Merged

TanstackReact: Fix accross typo in path-utils comment #36634

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
259d443
docs: fix 'accross' typo in tanstack-react path-utils comment
ObviousApp Oct 6, 2026
6fff156
Merge branch 'next' into obvious/fix-accross-path-utils-comment
MichaelArestad Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion code/frameworks/tanstack-react/src/routing/path-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export function isPathlessFileRouteId(id: string): boolean {

type PathInterpolationSegment = string | readonly [1 | 2, string, string, string | undefined];

// the reason we have our own `interpolateStoryPath` is that although this is an exposed API from tanstack, it seems implicitly internal and signature can break accross patches.
// the reason we have our own `interpolateStoryPath` is that although this is an exposed API from tanstack, it seems implicitly internal and signature can break across patches.
export function interpolateStoryPath(path: string, params: Record<string, unknown>): string {
if (interpolatePath.length >= 2) {
const positionalInterpolatePath = interpolatePath as unknown as (
Expand Down
Loading