Repository navigation
TanstackReact: Fix accross typo in path-utils comment - #36634
Conversation
There was a problem hiding this comment.
🤖 I am the Storybook contribution review bot; a human maintainer approved this message before it was posted.
Review phase: Runtime verification (stage 3 of 3)We are trying a three-stage automated review: architecture, code quality, and runtime verification. This message states which stages ran and which were skipped. A human maintainer approves each public message and makes the final decision. Please tell us whether the feedback and evidence are useful.
Result for 6fff156: runtime verification passed. Architecture and code quality review were skipped because this is a one-word comment fix. Thanks for the cleanup!
What we checked:
- The diff against
next(6c2b531) changes one word inside a//comment incode/frameworks/tanstack-react/src/routing/path-utils.ts(accross→across). No code changes, and the merge ofnextadds nothing else to the diff. - Lint (oxlint, repo config) and format (oxfmt) pass on the file.
tscreports no errors intanstack-react.
Not covered: a full monorepo compile and CI. The results above come from our local runs, not from this PR's CI.
Nothing blocking from our side. A maintainer makes the final merge decision.
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 1 | 1 | 0 |
| Self size | 208 KB | 195 KB | 🎉 -12 KB 🎉 |
| Dependency size | 28 KB | 28 KB | 0 B |
| Bundle Size Analyzer | Link | Link |
storybook
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 73 | 73 | 0 |
| Self size | 21.59 MB | 21.71 MB | 🚨 +123 KB 🚨 |
| Dependency size | 31.24 MB | 31.24 MB | 0 B |
| Bundle Size Analyzer | Link | Link |
@storybook/angular-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 20 | 20 | 0 |
| Self size | 23.62 MB | 23.62 MB | 🚨 +3 KB 🚨 |
| Dependency size | 11.57 MB | 11.55 MB | 🎉 -12 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/html-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 4 | 4 | 0 |
| Self size | 22 KB | 22 KB | 🚨 +12 B 🚨 |
| Dependency size | 271 KB | 259 KB | 🎉 -12 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/nextjs-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 100 | 100 | 0 |
| Self size | 1.42 MB | 1.42 MB | 🎉 -256 B 🎉 |
| Dependency size | 24.16 MB | 24.15 MB | 🎉 -16 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/preact-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 4 | 4 | 0 |
| Self size | 12 KB | 12 KB | 🎉 -12 B 🎉 |
| Dependency size | 289 KB | 276 KB | 🎉 -12 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/react-native-web-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 117 | 120 | 🚨 +3 🚨 |
| Self size | 104 KB | 29 KB | 🎉 -75 KB 🎉 |
| Dependency size | 26.10 MB | 26.28 MB | 🚨 +182 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/react-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 78 | 78 | 0 |
| Self size | 33 KB | 33 KB | 🎉 -18 B 🎉 |
| Dependency size | 21.28 MB | 21.26 MB | 🎉 -16 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/svelte-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 12 | 12 | 0 |
| Self size | 56 KB | 56 KB | 🚨 +27 B 🚨 |
| Dependency size | 30.73 MB | 30.72 MB | 🎉 -12 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/sveltekit
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 13 | 13 | 0 |
| Self size | 58 KB | 56 KB | 🎉 -2 KB 🎉 |
| Dependency size | 30.79 MB | 30.77 MB | 🎉 -12 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/tanstack-react
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 79 | 79 | 0 |
| Self size | 124 KB | 124 KB | 🎉 -145 B 🎉 |
| Dependency size | 21.31 MB | 21.30 MB | 🎉 -16 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/vue3-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 95 | 95 | 0 |
| Self size | 32 KB | 32 KB | 0 B |
| Dependency size | 18.78 MB | 18.75 MB | 🎉 -35 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/web-components-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 6 | 6 | 0 |
| Self size | 19 KB | 19 KB | 🚨 +24 B 🚨 |
| Dependency size | 530 KB | 423 KB | 🎉 -107 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/cli
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 179 | 179 | 0 |
| Self size | 884 KB | 859 KB | 🎉 -25 KB 🎉 |
| Dependency size | 87.04 MB | 87.16 MB | 🚨 +117 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/codemod
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 172 | 172 | 0 |
| Self size | 44 KB | 44 KB | 🎉 -426 B 🎉 |
| Dependency size | 85.52 MB | 85.65 MB | 🚨 +123 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
create-storybook
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 74 | 74 | 0 |
| Self size | 1.07 MB | 1.07 MB | 🎉 -6 KB 🎉 |
| Dependency size | 52.83 MB | 52.96 MB | 🚨 +123 KB 🚨 |
| Bundle Size Analyzer | node | node |
@storybook/vue3
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 91 | 91 | 0 |
| Self size | 232 KB | 209 KB | 🎉 -22 KB 🎉 |
| Dependency size | 18.22 MB | 18.22 MB | 0 B |
| Bundle Size Analyzer | Link | Link |
@storybook/web-components
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 4 | 4 | 0 |
| Self size | 196 KB | 101 KB | 🎉 -95 KB 🎉 |
| Dependency size | 126 KB | 126 KB | 0 B |
| Bundle Size Analyzer | Link | Link |
What I did
Fixed a misspelled word in a code comment:
accross→acrossin the comment aboveinterpolateStoryPathincode/frameworks/tanstack-react/src/routing/path-utils.ts. Comment-only change — no runtime, API, or behaviour change.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
None apply — the diff touches only the wording of a comment, which no test asserts on.
Manual testing
code/frameworks/tanstack-react/src/routing/path-utils.tsand read the comment aboveinterpolateStoryPath(line 52): it now reads "signature can break across patches" instead of the misspelled "accross"git grep -n 'accross' -- code/and confirm it returns no matchesDocumentation
No documentation updates needed — the change is inside a source code comment, not user-facing docs.
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsDeclare whether manual QA will be needed for this PR during the next release, through
qa:neededorqa:skipMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.Visual evidence: not applicable — comment-only change with no rendered output