Skip to content

Build: Fix oxfmt formatting in web-components csf-factories test - #36585

Merged
valentinpalkovic merged 1 commit into
nextfrom
fix/format-csf-factories-test
Oct 5, 2026
Merged

valentinpalkovic merged 1 commit into
nextfrom
fix/format-csf-factories-test

Conversation

@valentinpalkovic

Copy link
Copy Markdown
Contributor

What I did

fmt:check fails on next for code/renderers/web-components/src/csf-factories.test.ts. #36533 added html templates in the multi-line style used before oxfmt 0.70, which no longer matches. This PR runs oxfmt@0.70.0 on that file and changes nothing else. The diff only touches whitespace.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

Run yarn oxfmt --check code/renderers/web-components/src/csf-factories.test.ts. It should report that all matched files use the correct format.

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update MIGRATION.MD

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@valentinpalkovic valentinpalkovic added build Internal-facing build tooling & test updates ci:docs Run the CI jobs for documentation checks only. labels Oct 5, 2026
@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor
Fails
🚫

PR is not labeled with one of: ["qa:needed","qa:skip","qa:success"]

Generated by 🚫 dangerJS against 3f76ef8

@coderabbitai

coderabbitai Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

🧰 Additional context used
📚 Code guidelines (1)
.cursor/rules/spy-mocking.mdc — auto-discovered

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: eb482940-c2bf-46a5-ab36-13488cd6026e
📥 Commits

Reviewing files that changed from the base of the PR and between 829172f and 3f76ef8.

📒 Files selected for processing (1)
  • code/renderers/web-components/src/csf-factories.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.


Walkthrough

Three callbacks in the Web Components CSF factory tests were reformatted to use single-line template literals. Their returned markup and tested behavior are unchanged.

Changes

Web Components test formatting

Layer / File(s) Summary
Reformat test callbacks
code/renderers/web-components/src/csf-factories.test.ts
Three callbacks now use single-line template literals. Their markup and behavior are unchanged.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 3f76e

The formatter check passes, and the changed test callbacks are not rendered or asserted here; no actionable merge risk remains.

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@valentinpalkovic
valentinpalkovic merged commit 6526098 into next Oct 5, 2026
33 of 39 checks passed
@valentinpalkovic
valentinpalkovic deleted the fix/format-csf-factories-test branch October 5, 2026 09:25
@github-actions github-actions Bot mentioned this pull request Oct 5, 2026
2 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates ci:docs Run the CI jobs for documentation checks only.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants