Repository navigation
Manager: Capitalize GitHub and open the contributors link in a new tab on mobile - #36494
Conversation
…b in the mobile About page The mobile About page labeled its GitHub link "Github", and the Storybook Community link was the only external link without target="_blank".
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review. WalkthroughThe mobile About view corrects the GitHub label and opens the Storybook Community link in a new tab. Storybook stories check the visibility of About links and the updated GitHub accessible name. ChangesMobile About links
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to The About links and their accessible names are consistent, and the Community link opens in a new tab safely. No material merge risk is evident. ✨ Finishing Touches📝 Generate docstrings
Comment |
What I did
The mobile About page labeled its GitHub link "Github".
It also opened the "Storybook Community" contributors link in the current tab, while every other external link on the page opens in a new one.
This PR fixes both, and gives the
Defaultstory aplayfunction that checks the four links by their accessible names.The
AboutFocusTrappedstory inMobileNavigation.stories.tsxnow looks for the link by its new name.These changes were split out of #36137, where they did not belong.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
cd code && yarn storybook:ui.Mobile/AboutDefault story.Documentation
MIGRATION.MD
🤖 Generated with Claude Code