Repository navigation
Tests: Fix Preact React version expectation - #36309
Conversation
…eact version expectations
|
Heads-up on the failing Evidence (CircleCI public API):
This is the fresh-Next.js-app dependency-installation issue tracked by #36310 (unpinned vitest resolving to the Vitest 5 line, whose The addon-docs expectation change in this PR is unaffected: the job that runs it ( |
|
Follow-up on the second failing check, Evidence (CircleCI daily-generated workflows on bare
In this PR's run (build 2066797) the 19 failing unit tests are all in the codemods package (CRLF snapshot mismatches) and the CLI Both failing CircleCI jobs fail identically on |
Closes #
What I did
Preact sandboxes resolve React 18.3.1. Removing a condition which checks for React 16.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Caution
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
No additional manual testing applies: the change is covered by the e2e-sandbox daily workflow, which runs the affected test against the
preact-latest--vite---typescript---devandpreact-latest--vite---javascript---devsandboxes.Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsDeclare whether manual QA will be needed for this PR during the next release, through
qa:neededorqa:skipMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary Release - 🚫 Not run
This PR does not have a canary release associated.
In-repo PRs: add the
ci:canarylabel. Later pushes republish while the label remains.Fork PRs: the label does nothing (a later push must not auto-publish). A maintainer publishes from this repository with Run workflow and the
prinput.branchandshaare optional; if more than one is set, they must be the same commit. The fork author does not need to do anything.🔗 Obvious Project · 🧵 Obvious Thread