Repository navigation
CI: Remove obsolete test-storybooks-portable-vitest3 job and react-vitest-3 template - #36289
Merged
Merged
Conversation
…act-vitest-3 template The Vitest 4 floor raise (#36164) obsoleted the dedicated Vitest 3 kitchen-sink variant. Remove the job definition and its registration from the CircleCI config generator, and delete the test-storybooks/portable-stories-kitchen-sink/react-vitest-3 template that this job exclusively consumed. Validated by regenerating all four CircleCI workflows (normal, merged, daily, docs) before and after: normal/docs are byte-identical, merged/ daily differ only by the removed job, and tsc/oxlint/oxfmt are clean on the touched files.
Contributor
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 182 | 181 | 🎉 -1 🎉 |
| Self size | 92 KB | 92 KB | 🎉 -96 B 🎉 |
| Dependency size | 37.75 MB | 38.33 MB | 🚨 +581 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/ember
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 181 | 180 | 🎉 -1 🎉 |
| Self size | 13 KB | 13 KB | 🎉 -18 B 🎉 |
| Dependency size | 33.07 MB | 33.65 MB | 🚨 +580 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/nextjs
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 447 | 447 | 0 |
| Self size | 641 KB | 641 KB | 0 B |
| Dependency size | 61.37 MB | 62.25 MB | 🚨 +878 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/react-webpack5
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 267 | 266 | 🎉 -1 🎉 |
| Self size | 23 KB | 23 KB | 🎉 -12 B 🎉 |
| Dependency size | 50.29 MB | 50.87 MB | 🚨 +580 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/server-webpack5
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 194 | 193 | 🎉 -1 🎉 |
| Self size | 15 KB | 15 KB | 0 B |
| Dependency size | 39.03 MB | 39.61 MB | 🚨 +580 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/preset-react-webpack
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 153 | 152 | 🎉 -1 🎉 |
| Self size | 14 KB | 14 KB | 0 B |
| Dependency size | 34.41 MB | 34.99 MB | 🚨 +581 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
Sidnioulz
approved these changes
Sep 14, 2026
Sidnioulz
enabled auto-merge
September 14, 2026 10:49
This was referenced Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
The Vitest 4 floor raise (#36164) obsoleted the dedicated Vitest 3 kitchen-sink variant, but its CI step survived. This PR removes the dead weight:
definePortableStoryTestVitest3job definition (jobtest-storybooks-portable-vitest3, Playwright E2E againsttest-storybooks/portable-stories-kitchen-sink/react-vitest-3) and its registration ingetTestStorybooks()inscripts/ci/test-storybooks.ts.getTestStorybooksno longer uses itsworkflowparameter — removed it (and theWorkflowtype import), updating the single call site inscripts/ci/main.ts.test-storybooks/portable-stories-kitchen-sink/react-vitest-3/template directory that this job exclusively consumed. The sibling variants (react,vue3,svelte,nextjs) and the MCP test-storybook are untouched.No issue — orphaned by #36164.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Caution
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
No manual browser testing is needed — this PR only touches CI config generation and removes a template directory; there is no runtime Storybook behavior change. What I validated instead:
normal,merged,daily,docs) viayarn dlx jiti ./scripts/ci/main.ts --workflow=<workflow>before and after the change, and diffed:normalanddocs: byte-identical (the job was gated tomergedand above).mergedanddaily: 30 lines removed, 0 added — solely thetest-storybooks-portable-vitest3job definition, its workflow-list entry, and one inboundrequiresreference. No other job changed.grep vitest3finds 0 references in every generated config.git grepforreact-vitest-3,portable-vitest3,definePortableStoryTestVitest3(excludingcode/**/distbuild output): no remaining references. The onlyVitest3-pattern hits outside this diff areisVitest3_2To4in compileddistoutput ofaddon-vitest/create-storybook— legitimate runtime version-gating code, unrelated to this CI job.tsc --noEmit -p scripts/tsconfig.json: zero errors underscripts/(pre-existing errors incode/are unchanged base-branch noise from that config's import graph).oxlintandoxfmt --checkon both touched files: clean.To verify yourself: run
yarn dlx jiti ./scripts/ci/main.ts --workflow=mergedand confirm.circleci/config.generated.ymlcontains notest-storybooks-portable-vitest3job.Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsDeclare whether manual QA will be needed for this PR during the next release, through
qa:neededorqa:skipMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary Release - 🚫 Not run
This PR does not have a canary release associated.
In-repo PRs: add the
ci:canarylabel. Later pushes republish while the label remains.Fork PRs: the label does nothing (a later push must not auto-publish). A maintainer publishes from this repository with Run workflow and the
prinput.branchandshaare optional; if more than one is set, they must be the same commit. The fork author does not need to do anything.🔗 Obvious Project · 🧵 Obvious Thread