Repository navigation
Docs: Add encode-lessons-in-structure skill - #36249
Merged
Merged
Conversation
JReinhold
approved these changes
Sep 9, 2026
valentinpalkovic
marked this pull request as ready for review
September 9, 2026 19:25
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. WalkthroughChangesPrinciple-encoding skill
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to This change adds a shared documentation skill, its license, a Claude reference, and repository guidance. The documented wiring and validation indicate no remaining merge-readiness risk. Comment |
2 tasks done
2 of 9 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Add the encode-lessons-in-structure skill from Cursor’s pstack plugin so contributors can invoke its guidance for turning recurring corrections into enforceable checks.
The skill is copied into
.agents/skills/with its upstream MIT license. Thedisable-model-invocationsetting is omitted so agents can invoke it automatically when relevant. A.claude/skills/reference and anAGENTS.mdentry make it available through the repository’s existing conventions.Validation: ran
cd code && yarn fmt:write, verified that the skill matches upstream except for the removed invocation setting and that the license matches byte-for-byte, and verified that the Claude reference resolves to the canonical skill. This change contains only contributor documentation.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Caution
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
.agents/skills/principle-encode-lessons-in-structure/SKILL.mdand compare it with the linked upstream skill. The content should match except thatdisable-model-invocation: trueis omitted..claude/skills/principle-encode-lessons-in-structure/SKILL.mdand follow its relative reference. It should resolve to the canonical skill above.AGENTS.mdand confirm that the upstream MIT license is present beside the skill.Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsDeclare whether manual QA will be needed for this PR during the next release, through
qa:neededorqa:skipMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary Release - 🚫 Not run
This PR does not have a canary release associated.
In-repo PRs: add the
ci:canarylabel. Later pushes republish while the label remains.Fork PRs: the label does nothing (a later push must not auto-publish). A maintainer publishes from this repository with Run workflow and the
prinput.branchandshaare optional; if more than one is set, they must be the same commit. The fork author does not need to do anything.