Skip to content

Docs: Add encode-lessons-in-structure skill - #36249

Merged
valentinpalkovic merged 3 commits into
nextfrom
docs/add-encode-lessons-skill
Sep 9, 2026
Merged

valentinpalkovic merged 3 commits into
nextfrom
docs/add-encode-lessons-skill

Conversation

@valentinpalkovic

@valentinpalkovic valentinpalkovic commented Sep 9, 2026 •

Copy link
Copy Markdown
Contributor

What I did

Add the encode-lessons-in-structure skill from Cursor’s pstack plugin so contributors can invoke its guidance for turning recurring corrections into enforceable checks.

The skill is copied into .agents/skills/ with its upstream MIT license. The disable-model-invocation setting is omitted so agents can invoke it automatically when relevant. A .claude/skills/ reference and an AGENTS.md entry make it available through the repository’s existing conventions.

Validation: ran cd code && yarn fmt:write, verified that the skill matches upstream except for the removed invocation setting and that the license matches byte-for-byte, and verified that the Claude reference resolves to the canonical skill. This change contains only contributor documentation.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

Caution

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

  1. Open .agents/skills/principle-encode-lessons-in-structure/SKILL.md and compare it with the linked upstream skill. The content should match except that disable-model-invocation: true is omitted.
  2. Open .claude/skills/principle-encode-lessons-in-structure/SKILL.md and follow its relative reference. It should resolve to the canonical skill above.
  3. Follow the skill link under “Repository skills” in AGENTS.md and confirm that the upstream MIT license is present beside the skill.

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Declare whether manual QA will be needed for this PR during the next release, through qa:needed or qa:skip

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary Release - 🚫 Not run

This PR does not have a canary release associated.

In-repo PRs: add the ci:canary label. Later pushes republish while the label remains.

Fork PRs: the label does nothing (a later push must not auto-publish). A maintainer publishes from this repository with Run workflow and the pr input. branch and sha are optional; if more than one is set, they must be the same commit. The fork author does not need to do anything.

@valentinpalkovic valentinpalkovic added documentation ci:docs Run the CI jobs for documentation checks only. qa:skip Pull Requests that do not need any QA. (e.g. documentation) labels Sep 9, 2026
@valentinpalkovic valentinpalkovic self-assigned this Sep 9, 2026
@valentinpalkovic
valentinpalkovic marked this pull request as ready for review September 9, 2026 19:25
@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: c72d7746-6e69-407b-9031-bc87004b8c94

📥 Commits

Reviewing files that changed from the base of the PR and between 78f319b and 8e38dae.

📒 Files selected for processing (4)
  • .agents/skills/principle-encode-lessons-in-structure/LICENSE
  • .agents/skills/principle-encode-lessons-in-structure/SKILL.md
  • .claude/skills/principle-encode-lessons-in-structure/SKILL.md
  • AGENTS.md

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


Walkthrough

Changes

Principle-encoding skill

Layer / File(s) Summary
Skill definition and repository wiring
.agents/skills/principle-encode-lessons-in-structure/SKILL.md, .agents/skills/principle-encode-lessons-in-structure/LICENSE, .claude/skills/principle-encode-lessons-in-structure/SKILL.md, AGENTS.md
Adds the skill definition and MIT license. The Claude skill references the shared definition. AGENTS.md documents the repository skill locations and the new skill.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 8e38d

This change adds a shared documentation skill, its license, a Claude reference, and repository guidance. The documented wiring and validation indicate no remaining merge-readiness risk.


Comment @coderabbitai help to get the list of available commands.

@valentinpalkovic
valentinpalkovic merged commit 1e8b436 into next Sep 9, 2026
29 checks passed
@valentinpalkovic
valentinpalkovic deleted the docs/add-encode-lessons-skill branch September 9, 2026 19:36
@github-actions github-actions Bot mentioned this pull request Sep 9, 2026
2 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:docs Run the CI jobs for documentation checks only. documentation qa:skip Pull Requests that do not need any QA. (e.g. documentation)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants