Repository navigation
Vitest: Revert removal of workarounds obsoleted by the Vitest 4 floor - #36198
Merged
Merged
Conversation
valentinpalkovic
approved these changes
Sep 5, 2026
valentinpalkovic
deleted the
revert/pr-36188-vitest-workaround-removal
branch
September 5, 2026 08:08
2 tasks done
1 of 9 tasks
2 of 9 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #36188
What I did
This PR reverts #36188 (merge commit 32f2a8b), restoring the 8 affected Vitest-related files to their pre-merge state:
code/addons/vitest/src/node/vitest-manager.tscode/addons/vitest/src/vitest-plugin/index.tscode/core/src/actions/loaders.tscode/core/src/babel/index.tscode/core/src/babel/vitest-config-helpers.test.tscode/core/src/babel/vitest-config-helpers.tscode/core/src/cli/AddonVitestService.test.tscode/core/src/cli/AddonVitestService.tsWhy: #36188 was automerged by
obvious-autobuild[bot]immediately after review, without maintainer authorization. This revert takesnextback to the pre-merge tree (verified:git diff HEAD 1720e5a29f3b5b9933aa7c9462839feaeb10152aover these paths is empty). The same changes will be re-landed through a fresh PR stacked on this branch. Merge of this PR must be performed by a human — do not enable auto-merge.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
The revert restores the unit tests removed by #36188 (
code/core/src/babel/vitest-config-helpers.test.ts,code/core/src/cli/AddonVitestService.test.ts); CI runs them as part of this PR.Manual testing
Caution
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
No manual testing is necessary: this PR only restores the exact pre-merge state of the affected files (tree-verified against 1720e5a), which is the state
nexthad before #36188 merged. CI provides the verification.Documentation
MIGRATION.MD
No documentation update needed: the revert returns the code to the pre-merge state.
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsDeclare whether manual QA will be needed for this PR during the next release, through
qa:neededorqa:skipMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary Release - 🚫 Not run
This PR does not have a canary release associated.
In-repo PRs: add the
ci:canarylabel. Later pushes republish while the label remains.Fork PRs: the label does nothing (a later push must not auto-publish). A maintainer publishes from this repository with Run workflow and the
prinput.branchandshaare optional; if more than one is set, they must be the same commit. The fork author does not need to do anything.🔗 Obvious Project · 🧵 Obvious Thread