Repository navigation
Docs: Remove outdated prerelease reference and fix typo - #36119
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. WalkthroughThe contributor documentation removes a prerelease version example from the ChangesStorybook documentation
Merge Risk: ⚪ Minimal · up to This PR makes two localized documentation corrections with no runtime or product behavior impact, so no actionable merge-blocking risk remains. ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Comment |
Hi @Thodorr, Thank you for this. Both changes are correct, and the first one is the kind of documentation rot that is very easy to read straight past. The The I reviewed this as a documentation-only change. It touches one The red checks are not yours to fixThe PR currently shows a failing Danger run. None of it is caused by your change: Those label groups are applied by maintainers, and the approving review has to come from a human on the core team. There is genuinely nothing for you to do here, so please don't push extra commits trying to turn CI green. From a content review perspective this is ready. Handing it over to a maintainer for the labels and the approving review. |
jonniebigodes
left a comment
There was a problem hiding this comment.
@Thodorr, thanks for taking the time to put this pull request together and help us improve the documentation. We appreciate it 🙏
I've checked, and all is good on my end; I'll gladly merge this once the checklist clears.
Hope you have a fantastic day.
Stay safe
What I did
7.0.0-alpha.47prerelease example.inDevelopmentflag" to "aninDevelopmentflag".Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
No runtime testing is necessary. The changes are text-only in
docs/contribute/code.mdxand can be verified by reviewing the rendered Markdown.Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsDeclare whether manual QA will be needed for this PR during the next release, through
qa:neededorqa:skipMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>