Skip to content

Vue: Generate Story snippets from docgen payload - #35815

Merged
huang-julien merged 19 commits into
nextfrom
julien/story-docs-3-args-snippets
Aug 13, 2026
Merged

huang-julien merged 19 commits into
nextfrom
julien/story-docs-3-args-snippets

Conversation

@huang-julien

@huang-julien huang-julien commented Aug 8, 2026 •

Copy link
Copy Markdown
Contributor

Closes #

What I did

This PR makes the Vue renderer synthesizes the snippet statically from the story's args plus fresh docgen, for the cases where the args can be read from the AST.

Each merged arg (meta.args ← story.args) is classified against the docgen payload and rendered into an SFC:

  • slots (docgen slots category) → children or <template #name>
  • props with an update: event → v-model:name with a hoisted ref()
  • objects and arrays → hoisted consts in <script lang="ts" setup>
  • everything else → attribute or :bound prop

Stories whose args can't be statically read (an identifier reference, a spread) get an error instead of a snippet.

Different examples are available in the fixtures.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing


Caution

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Declare whether manual QA will be needed for this PR during the next release, through qa:needed or qa:skip

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

@huang-julien huang-julien added feature request vue ci:normal Run our default set of CI jobs (choose this for most PRs). qa:skip Pull Requests that do not need any QA. (e.g. documentation) labels Aug 8, 2026
@storybook-app-bot

storybook-app-bot Bot commented Aug 8, 2026 •

Copy link
Copy Markdown
Contributor

Package Benchmarks

Commit: 014c4a0, ran on 13 August 2026 at 07:49:39 UTC

The following packages have significant changes to their size or dependencies:

@storybook/vue3-vite

Before After Difference
Dependency count 94 94 0
Self size 31 KB 31 KB 🚨 +24 B 🚨
Dependency size 18.44 MB 18.45 MB 🚨 +17 KB 🚨
Bundle Size Analyzer Link Link

@storybook/vue3

Before After Difference
Dependency count 90 90 0
Self size 102 KB 118 KB 🚨 +16 KB 🚨
Dependency size 18.10 MB 18.10 MB 0 B
Bundle Size Analyzer Link Link

Comment thread code/renderers/vue3/src/story-docs/build-story-docs.ts
Comment thread code/renderers/vue3/src/story-docs/render-sfc.ts Outdated
@huang-julien
huang-julien marked this pull request as ready for review August 10, 2026 12:09
@huang-julien
huang-julien force-pushed the julien/story-docs-3-args-snippets branch from aacb032 to 4597db7 Compare August 10, 2026 12:09
@coderabbitai

coderabbitai Bot commented Aug 10, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

Walkthrough

This PR adds static Vue SFC snippet generation for story arguments. It classifies props, slots, events, and models, integrates docgen metadata, supports fixture-tree testing, and adds parity validation with expected omissions.

Changes

Vue story-doc generation

Layer / File(s) Summary
Argument classification and SFC rendering
code/renderers/vue3/src/story-docs/classify-value.ts, classify-args.ts, render-sfc.ts, *.test.ts
Classifies values and arguments, then renders props, slots, models, events, hoisted bindings, and <script setup> blocks.
Docgen-aware story enrichment
code/renderers/vue3/src/story-docs/build-story-docs.ts, code/lib/docgen-harness/src/vue3/story-docs/build-story-docs.test.ts
Loads docgen metadata, resolves components, validates story arguments, and attaches generated snippets or warnings.
Fixture harness and parity validation
code/lib/docgen-harness/src/vue3/story-docs/snippet-parity.test.ts, code/lib/docgen-harness/src/compare/expect-current-or-better.ts, code/lib/docgen-harness/src/vue3/__testfixtures__/snippet-parity-summary.md
Adds fixture discovery, declared omission handling, parity tests, and a generated comparison report.
Docgen fixture snapshots
code/lib/docgen-harness/src/vue3/__testfixtures__/*/story-docs.payload.snapshot
Adds generated snippets for cross-file types, runtime props, slots, enums, recursive types, intersections, events, and v-model bindings.
Story-docs fixture snapshots
code/lib/docgen-harness/src/vue3/story-docs/__testfixtures__/*
Adds snippets and stories covering formatting, slots, CSF4, legacy assigned args, event listeners, and v-model bindings.

Sequence Diagram(s)

sequenceDiagram
  participant StoryFile
  participant buildStoryDocs
  participant classifyArgs
  participant renderSfcSnippet
  StoryFile->>buildStoryDocs: provide story metadata and args
  buildStoryDocs->>classifyArgs: classify args with docgen metadata
  classifyArgs-->>buildStoryDocs: return classified args or warnings
  buildStoryDocs->>renderSfcSnippet: render classified args
  renderSfcSnippet-->>buildStoryDocs: return Vue SFC snippet
Loading

Possibly related PRs

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 6

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@code/lib/docgen-harness/src/vue3/__testfixtures__/props-basic-types/story-docs.payload.snapshot`:
- Line 27: Update the PropsBasicTypes Vue fixture to hoist the Symbol value into
the script as a token constant, then bind the component’s token prop with
:token="token" instead of calling Symbol directly in the template; leave the
other bindings unchanged.

In
`@code/lib/docgen-harness/src/vue3/__testfixtures__/props-ts-enum/story-docs.payload.snapshot`:
- Line 12: Update renderSfcSnippet() to include the story-local Severity import
in the generated SFC script, or replace the emitted severity value with a
self-contained equivalent so Severity.Warning is resolvable; then regenerate the
props-ts-enum story-docs payload snapshot.

In `@code/lib/docgen-harness/src/vue3/story-docs/build-story-docs.test.ts`:
- Around line 1-11: Replace host filesystem access with memfs in
build-story-docs.test.ts, mocking node:fs and node:fs/promises, then reset and
seed vol in beforeEach with the required fixtures. In snippet-parity.test.ts,
mock node:fs with memfs and configure filesystem spies using vi.mock(..., { spy:
true }) and vi.mocked().

In `@code/renderers/vue3/src/story-docs/classify-args.ts`:
- Around line 102-110: Update the classification logic around unwrapValue and
hasSpreadValue to recursively inspect nested object and array values for
Identifier expressions, not only when the top-level value is an Identifier.
Return the existing unsupported-args error for the referenced identifier before
invoking the SFC renderer, while preserving current handling for top-level
identifiers and spread values.

In `@code/renderers/vue3/src/story-docs/render-sfc.ts`:
- Around line 127-128: Update the StringLiteral handling in render-sfc.ts to
HTML-escape slot text before inserting it into generated template content. Also
update the attribute-value generation around lines 163-170 to encode values
before wrapping them with the attribute delimiter, preserving literal characters
such as quotes and markup safely in both contexts.
- Around line 84-87: Update the hoisted-binding logic in render-sfc.ts at lines
84-87 and 102-107 to generate unique valid TypeScript identifier names instead
of using raw CSF arg or model names. Apply the same allocator to object/array
prop bindings and model refs, ensuring generated names avoid collisions with
imported bindings such as Vue’s ref and are used consistently in declarations
and template attributes.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e51aa200-6b71-448f-92e9-495ae0519a9a

📥 Commits

Reviewing files that changed from the base of the PR and between 2b7f6be and 4597db7.

📒 Files selected for processing (44)
  • code/lib/docgen-harness/src/vue3/__testfixtures__/cross-file-composed-utility/story-docs.payload.snapshot
  • code/lib/docgen-harness/src/vue3/__testfixtures__/cross-file-extended-interface/story-docs.payload.snapshot
  • code/lib/docgen-harness/src/vue3/__testfixtures__/cross-file-imported-interface/story-docs.payload.snapshot
  • code/lib/docgen-harness/src/vue3/__testfixtures__/cross-file-props-spread/story-docs.payload.snapshot
  • code/lib/docgen-harness/src/vue3/__testfixtures__/cross-file-runtime-props/story-docs.payload.snapshot
  • code/lib/docgen-harness/src/vue3/__testfixtures__/cross-file-union-alias/story-docs.payload.snapshot
  • code/lib/docgen-harness/src/vue3/__testfixtures__/define-expose/story-docs.payload.snapshot
  • code/lib/docgen-harness/src/vue3/__testfixtures__/define-props-destructured/story-docs.payload.snapshot
  • code/lib/docgen-harness/src/vue3/__testfixtures__/define-props-runtime-array/story-docs.payload.snapshot
  • code/lib/docgen-harness/src/vue3/__testfixtures__/define-props-runtime-object/story-docs.payload.snapshot
  • code/lib/docgen-harness/src/vue3/__testfixtures__/define-slots-with-props/story-docs.payload.snapshot
  • code/lib/docgen-harness/src/vue3/__testfixtures__/events-jsdoc/story-docs.payload.snapshot
  • code/lib/docgen-harness/src/vue3/__testfixtures__/jsdoc-tags/story-docs.payload.snapshot
  • code/lib/docgen-harness/src/vue3/__testfixtures__/prop-slot-name-collision/story-docs.payload.snapshot
  • code/lib/docgen-harness/src/vue3/__testfixtures__/props-basic-types/story-docs.payload.snapshot
  • code/lib/docgen-harness/src/vue3/__testfixtures__/props-generic/story-docs.payload.snapshot
  • code/lib/docgen-harness/src/vue3/__testfixtures__/props-ts-enum/story-docs.payload.snapshot
  • code/lib/docgen-harness/src/vue3/__testfixtures__/props-union-enum/story-docs.payload.snapshot
  • code/lib/docgen-harness/src/vue3/__testfixtures__/recursive-type/story-docs.payload.snapshot
  • code/lib/docgen-harness/src/vue3/__testfixtures__/runtime-multi-constructor/story-docs.payload.snapshot
  • code/lib/docgen-harness/src/vue3/__testfixtures__/runtime-proptype-cast/story-docs.payload.snapshot
  • code/lib/docgen-harness/src/vue3/__testfixtures__/slots-template-only/story-docs.payload.snapshot
  • code/lib/docgen-harness/src/vue3/__testfixtures__/slots/story-docs.payload.snapshot
  • code/lib/docgen-harness/src/vue3/__testfixtures__/snippet-parity-summary.md
  • code/lib/docgen-harness/src/vue3/__testfixtures__/type-intersection-whole/story-docs.payload.snapshot
  • code/lib/docgen-harness/src/vue3/__testfixtures__/type-intersection/story-docs.payload.snapshot
  • code/lib/docgen-harness/src/vue3/__testfixtures__/v-model/story-docs.payload.snapshot
  • code/lib/docgen-harness/src/vue3/story-docs/__testfixtures__/args-formatting/ArgsFormattingButton.vue
  • code/lib/docgen-harness/src/vue3/story-docs/__testfixtures__/args-formatting/input.stories.ts
  • code/lib/docgen-harness/src/vue3/story-docs/__testfixtures__/args-formatting/story-docs.payload.snapshot
  • code/lib/docgen-harness/src/vue3/story-docs/__testfixtures__/as-cast/story-docs.payload.snapshot
  • code/lib/docgen-harness/src/vue3/story-docs/__testfixtures__/basic/story-docs.payload.snapshot
  • code/lib/docgen-harness/src/vue3/story-docs/__testfixtures__/csf4/CsfFourButton.vue
  • code/lib/docgen-harness/src/vue3/story-docs/__testfixtures__/csf4/story-docs.payload.snapshot
  • code/lib/docgen-harness/src/vue3/story-docs/__testfixtures__/import-override/story-docs.payload.snapshot
  • code/lib/docgen-harness/src/vue3/story-docs/__testfixtures__/prop-slot-collision/story-docs.payload.snapshot
  • code/lib/docgen-harness/src/vue3/story-docs/__testfixtures__/slots/story-docs.payload.snapshot
  • code/lib/docgen-harness/src/vue3/story-docs/__testfixtures__/unsupported-args/story-docs.payload.snapshot
  • code/lib/docgen-harness/src/vue3/story-docs/__testfixtures__/v-model/story-docs.payload.snapshot
  • code/lib/docgen-harness/src/vue3/story-docs/build-story-docs.test.ts
  • code/lib/docgen-harness/src/vue3/story-docs/snippet-parity.test.ts
  • code/renderers/vue3/src/story-docs/build-story-docs.ts
  • code/renderers/vue3/src/story-docs/classify-args.ts
  • code/renderers/vue3/src/story-docs/render-sfc.ts

Comment thread code/renderers/vue3/src/story-docs/classify-args.ts Outdated
Comment thread code/renderers/vue3/src/story-docs/render-sfc.ts Outdated
Comment thread code/renderers/vue3/src/story-docs/render-sfc.ts Outdated
@huang-julien
huang-julien force-pushed the julien/story-docs-3-args-snippets branch 2 times, most recently from 0c85123 to 700f063 Compare August 11, 2026 12:37

@valentinpalkovic valentinpalkovic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thermo-nuclear code quality review

Note

This review was produced with the thermo-nuclear code quality review skill and is AI-assisted. Every claim below was verified by running the code, not by reading it alone. Take the prioritisation with a grain of salt and push back where I got it wrong.

What I ran: both suites on this branch (renderer: 3 files / 5 tests pass, docgen-harness: 2 files / 73 tests pass), plus probes against classifyArgs + renderSfcSnippet and against generateSourceCode, to capture real output for the comparisons below.

Verdict: the feature is worth having and the fixture/snapshot discipline is genuinely strong. My concern is structural, and I would like to resolve it before this lands.

  1. This stands up a second implementation of Vue's SFC snippet grammar next to the one in src/docs/sourceDecorator.ts. The two already disagree in seven observable ways, and the parity harness cannot see any of them, because compareSnippet diffs represented names only and scores a candidate-only name as an improvement.
  2. The "what is statically renderable" decision is split across classify-args.ts and render-sfc.ts, and they contradict each other. Bare identifiers are rejected; the same identifier as a callee, a member expression or inside new is inlined into a template that never defines it.
  3. That split produces a user-visible bug on a completely ordinary story: args: { a: undefined } errors the whole story instead of dropping the arg.
  4. There are three different failure policies for "cannot render this arg" (silent drop, silent whole-story skip, hard error), while StoryDoc.warning already models the correct middle ground and is unused.
  5. commands.extractDocgen is the wrong door on core/docgen and re-runs the full provider chain per story file.

Severity is marked on each comment: HIGH / MIDDLE / LOW / NIT. Happy to pair on the shared-printer extraction if that helps get it over the finish line.

Comment thread code/renderers/vue3/src/story-docs/render-sfc.ts
Comment thread code/renderers/vue3/src/story-docs/render-sfc.ts Outdated
Comment thread code/renderers/vue3/src/story-docs/classify-args.ts Outdated
Comment thread code/renderers/vue3/src/story-docs/classify-args.ts Outdated
Comment thread code/renderers/vue3/src/story-docs/build-story-docs.ts Outdated
Comment thread code/renderers/vue3/src/story-docs/render-sfc.ts Outdated
Comment thread code/renderers/vue3/src/story-docs/render-sfc.ts Outdated
Comment thread code/renderers/vue3/src/story-docs/render-sfc.ts
Comment thread code/lib/docgen-harness/src/vue3/story-docs/snippet-parity.test.ts Outdated

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@code/lib/docgen-harness/src/compare/expect-current-or-better.ts`:
- Around line 35-40: Update the comparison flow around compareSnippet and the
stale declaration check so violations other than lost-representation, especially
unparsable-candidate, are reported first. Return or throw the candidate-parsing
violation before evaluating declaredOmissions against omitted, while preserving
the existing stale-declaration handling for lost-representation results.

In
`@code/lib/docgen-harness/src/vue3/story-docs/__testfixtures__/args-formatting/story-docs.payload.snapshot`:
- Around line 11-21: Escape the nested double quotes in the snapshot’s outer
quoted snippet value, specifically the lang="ts" attribute in the SFC script
tag, then regenerate the args-formatting story-docs snapshot so the payload
remains parseable.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 901b7198-cda2-4a1d-9811-5a464841a605

📥 Commits

Reviewing files that changed from the base of the PR and between 0a1f6dc and 1d95adb.

📒 Files selected for processing (17)
  • code/lib/docgen-harness/src/compare/expect-current-or-better.ts
  • code/lib/docgen-harness/src/vue3/__testfixtures__/props-basic-types/story-docs.payload.snapshot
  • code/lib/docgen-harness/src/vue3/__testfixtures__/props-ts-enum/story-docs.payload.snapshot
  • code/lib/docgen-harness/src/vue3/__testfixtures__/v-model/story-docs.payload.snapshot
  • code/lib/docgen-harness/src/vue3/story-docs/__testfixtures__/args-formatting/input.stories.ts
  • code/lib/docgen-harness/src/vue3/story-docs/__testfixtures__/args-formatting/story-docs.payload.snapshot
  • code/lib/docgen-harness/src/vue3/story-docs/__testfixtures__/csf1-legacy/input.stories.ts
  • code/lib/docgen-harness/src/vue3/story-docs/__testfixtures__/csf1-legacy/story-docs.payload.snapshot
  • code/lib/docgen-harness/src/vue3/story-docs/__testfixtures__/v-model/story-docs.payload.snapshot
  • code/lib/docgen-harness/src/vue3/story-docs/snippet-parity.test.ts
  • code/renderers/vue3/src/story-docs/build-story-docs.ts
  • code/renderers/vue3/src/story-docs/classify-args.test.ts
  • code/renderers/vue3/src/story-docs/classify-args.ts
  • code/renderers/vue3/src/story-docs/classify-value.test.ts
  • code/renderers/vue3/src/story-docs/classify-value.ts
  • code/renderers/vue3/src/story-docs/render-sfc.test.ts
  • code/renderers/vue3/src/story-docs/render-sfc.ts
🚧 Files skipped from review as they are similar to previous changes (7)
  • code/lib/docgen-harness/src/vue3/testfixtures/v-model/story-docs.payload.snapshot
  • code/lib/docgen-harness/src/vue3/testfixtures/props-basic-types/story-docs.payload.snapshot
  • code/lib/docgen-harness/src/vue3/story-docs/testfixtures/v-model/story-docs.payload.snapshot
  • code/renderers/vue3/src/story-docs/render-sfc.ts
  • code/lib/docgen-harness/src/vue3/testfixtures/props-ts-enum/story-docs.payload.snapshot
  • code/lib/docgen-harness/src/vue3/story-docs/snippet-parity.test.ts
  • code/renderers/vue3/src/story-docs/build-story-docs.ts

Comment thread code/lib/docgen-harness/src/compare/expect-current-or-better.ts

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@code/lib/docgen-harness/src/vue3/story-docs/__testfixtures__/event-listener/input.stories.ts`:
- Line 19: Replace the raw console.log in the onSubmit handler of the
event-listener fixture with a typed no-op handler that preserves the listener
coverage without producing output, then regenerate or update the corresponding
story-docs.payload.snapshot to reflect the fixture change.

In `@code/renderers/vue3/src/story-docs/classify-args.ts`:
- Around line 97-105: Update the function classification flow around declared
events and props to inspect function bodies for non-local references, including
captured values and spreads, before assigning the hoist plan. Only hoist
self-contained functions; route unresolved functions through the existing
unresolved-argument omission and warning path, preserving current event/prop
classification for valid functions.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f67fc72d-814a-41e7-b6f9-6155ae521d87

📥 Commits

Reviewing files that changed from the base of the PR and between 1d95adb and 24e69b2.

📒 Files selected for processing (12)
  • code/lib/docgen-harness/src/vue3/__testfixtures__/events-jsdoc/story-docs.payload.snapshot
  • code/lib/docgen-harness/src/vue3/__testfixtures__/props-basic-types/story-docs.payload.snapshot
  • code/lib/docgen-harness/src/vue3/__testfixtures__/snippet-parity-summary.md
  • code/lib/docgen-harness/src/vue3/story-docs/__testfixtures__/event-listener/EventListenerForm.vue
  • code/lib/docgen-harness/src/vue3/story-docs/__testfixtures__/event-listener/input.stories.ts
  • code/lib/docgen-harness/src/vue3/story-docs/__testfixtures__/event-listener/story-docs.payload.snapshot
  • code/lib/docgen-harness/src/vue3/story-docs/build-story-docs.test.ts
  • code/renderers/vue3/src/story-docs/build-story-docs.ts
  • code/renderers/vue3/src/story-docs/classify-args.test.ts
  • code/renderers/vue3/src/story-docs/classify-args.ts
  • code/renderers/vue3/src/story-docs/render-sfc.test.ts
  • code/renderers/vue3/src/story-docs/render-sfc.ts
🚧 Files skipped from review as they are similar to previous changes (6)
  • code/lib/docgen-harness/src/vue3/testfixtures/props-basic-types/story-docs.payload.snapshot
  • code/lib/docgen-harness/src/vue3/testfixtures/snippet-parity-summary.md
  • code/renderers/vue3/src/story-docs/render-sfc.ts
  • code/lib/docgen-harness/src/vue3/story-docs/build-story-docs.test.ts
  • code/renderers/vue3/src/story-docs/build-story-docs.ts
  • code/renderers/vue3/src/story-docs/render-sfc.test.ts

Comment thread code/renderers/vue3/src/story-docs/classify-args.ts Outdated
@huang-julien
huang-julien force-pushed the julien/story-docs-3-args-snippets branch from 0252797 to 9515c68 Compare August 11, 2026 18:03
Comment thread code/lib/docgen-harness/src/vue3/__testfixtures__/snippet-parity-summary.md Outdated
Comment thread code/renderers/vue3/src/story-docs/build-story-docs.ts
Comment thread code/renderers/vue3/src/story-docs/classify-args.test.ts
@huang-julien
huang-julien force-pushed the julien/story-docs-3-args-snippets branch 2 times, most recently from 955558b to 87c931f Compare August 12, 2026 09:43
@huang-julien
huang-julien force-pushed the julien/story-docs-3-args-snippets branch from 87c931f to de74833 Compare August 12, 2026 13:51
@huang-julien
huang-julien force-pushed the julien/story-docs-3-args-snippets branch from de74833 to 014c4a0 Compare August 12, 2026 16:14
@huang-julien
huang-julien merged commit 242ca18 into next Aug 13, 2026
139 of 142 checks passed
@huang-julien
huang-julien deleted the julien/story-docs-3-args-snippets branch August 13, 2026 09:40
@github-actions github-actions Bot mentioned this pull request Aug 13, 2026
2 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:normal Run our default set of CI jobs (choose this for most PRs). feature request qa:skip Pull Requests that do not need any QA. (e.g. documentation) vue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants