Skip to content

Angular: Fix @angular/forms version to 21 in sandbox#35112

Merged
Sidnioulz merged 2 commits into
nextfrom
sidnioulz/fix-angular-forms-version
Jun 9, 2026
Merged

Angular: Fix @angular/forms version to 21 in sandbox#35112
Sidnioulz merged 2 commits into
nextfrom
sidnioulz/fix-angular-forms-version

Conversation

@Sidnioulz

@Sidnioulz Sidnioulz commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

What I did

Forced @angular/forms to stay on v21 to match other deps instead of going to v22.

Avoids this kind of CI failure.

Might need to be adjusted again in the near future once ng new starts releasing Angular 22, time will tell.

Checklist for Contributors

ø

Manual testing

  • Create angular sandbox
  • Go to sandbox and run build-storybook

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • Chores
    • Updated Angular CLI sandbox template dependency versioning to use a pinned version for stability.

@Sidnioulz Sidnioulz self-assigned this Jun 9, 2026
Copilot AI review requested due to automatic review settings June 9, 2026 13:40
@Sidnioulz Sidnioulz added build Internal-facing build tooling & test updates ci:normal Run our default set of CI jobs (choose this for most PRs). qa:skip Pull Requests that do not need any QA. labels Jun 9, 2026
@Sidnioulz Sidnioulz moved this to In Progress in Core Team Projects Jun 9, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Pins @angular/forms to an Angular v21 release in the Angular CLI sandbox template to prevent dependency drift (forms jumping to v22) that can break CI sandbox builds.

Changes:

  • Update the Angular CLI “Latest” sandbox template to install @angular/forms@21.2.16 instead of @latest.
  • Add an inline note indicating the pin should be revisited when Angular CLI starts generating Angular v22 projects by default.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread code/lib/cli-storybook/src/sandbox-templates.ts
@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d9ac28ee-300f-4689-85e4-fcaf1c1cd660

📥 Commits

Reviewing files that changed from the base of the PR and between d5f75ee and 6f7b4a7.

📒 Files selected for processing (1)
  • code/lib/cli-storybook/src/sandbox-templates.ts

📝 Walkthrough

Walkthrough

Pinned the @angular/forms dependency to version 21.2.16 in the Angular CLI sandbox template configuration, replacing the previously flexible @latest reference.

Changes

Angular Forms Version Pin

Layer / File(s) Summary
Angular forms version pin
code/lib/cli-storybook/src/sandbox-templates.ts
Updated the angular-cli/default-ts template's modifications.extraDependencies to pin @angular/forms to 21.2.16 with a comment about moving the pin later.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • storybookjs/storybook#33955: Both PRs modify Angular v21-related version information—this PR pins @angular/forms to 21.2.16 in an Angular sandbox template, while retrieved PR updates the documented Angular supported version range to < 22.0 (covering v21).
  • storybookjs/storybook#33098: Both PRs modify code/lib/cli-storybook/src/sandbox-templates.ts modifications.extraDependencies for Angular sandboxes by changing the @angular/forms version spec across different templates.
  • storybookjs/storybook#33553: Both PRs modify code/lib/cli-storybook/src/sandbox-templates.ts to change the Angular CLI template's modifications.extraDependencies for @angular/forms.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands and usage tips.

@Sidnioulz Sidnioulz merged commit 79b2e1f into next Jun 9, 2026
134 of 143 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Core Team Projects Jun 9, 2026
@Sidnioulz Sidnioulz deleted the sidnioulz/fix-angular-forms-version branch June 9, 2026 14:38
Sidnioulz added a commit that referenced this pull request Jun 9, 2026
…s-version

Angular: Fix @angular/forms version to 21 in sandbox
@github-actions github-actions Bot mentioned this pull request Jun 9, 2026
24 tasks
Sidnioulz added a commit that referenced this pull request Jun 9, 2026
…s-version

Angular: Fix @angular/forms version to 21 in sandbox
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates ci:normal Run our default set of CI jobs (choose this for most PRs). qa:skip Pull Requests that do not need any QA.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants