Skip to content

Build: Angular CLI sandbox prerelease fix#33553

Merged
ndelangen merged 5 commits into
nextfrom
norbert/fix-angular-prerelease
Jan 15, 2026
Merged

Build: Angular CLI sandbox prerelease fix#33553
ndelangen merged 5 commits into
nextfrom
norbert/fix-angular-prerelease

Conversation

@ndelangen
Copy link
Copy Markdown
Member

@ndelangen ndelangen commented Jan 15, 2026

Closes #

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

Caution

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • Chores
    • Removed unnecessary dependencies from the Angular CLI prerelease template configuration.

✏️ Tip: You can customize this high-level summary in your review settings.

@ndelangen ndelangen added angular ci:daily Run the CI jobs that normally run in the daily job. labels Jan 15, 2026
@ndelangen ndelangen self-assigned this Jan 15, 2026
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Jan 15, 2026

View your CI Pipeline Execution ↗ for commit 908d8ba

Command Status Duration Result
nx run-many -t compile,check,knip,test,pretty-d... ❌ Failed 19m 44s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-15 14:54:18 UTC

@ndelangen ndelangen added the build Internal-facing build tooling & test updates label Jan 15, 2026
@ndelangen ndelangen added ci:normal Run our default set of CI jobs (choose this for most PRs). and removed ci:daily Run the CI jobs that normally run in the daily job. labels Jan 15, 2026
@ndelangen ndelangen marked this pull request as ready for review January 15, 2026 14:32
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 15, 2026

📝 Walkthrough

Walkthrough

The change comments out the extraDependencies array in the angular-cli/prerelease sandbox template, removing two dependencies (@standard-schema/spec@^1 and @angular/forms@next) from being automatically installed during template setup.

Changes

Cohort / File(s) Summary
Angular CLI Prerelease Template Configuration
code/lib/cli-storybook/src/sandbox-templates.ts
Commented out extraDependencies entry for angular-cli/prerelease template, removing @standard-schema/spec@^1 and @angular/forms@next from the template's dependency modifications

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

✨ Finishing touches
  • 📝 Generate docstrings

🧹 Recent nitpick comments
code/lib/cli-storybook/src/sandbox-templates.ts (1)

646-649: Add a TODO comment explaining why this is commented out and when to re-enable.

Commenting out extraDependencies without an explanatory comment makes it difficult to track:

  1. What issue necessitated this change
  2. When it should be restored
  3. Whether the dependencies are permanently unnecessary or temporarily problematic

Other templates in this file use actual code comments to document known issues (e.g., lines 160, 639, 695 referencing GitHub issues). Consider following the same pattern here.

Suggested improvement
   'angular-cli/prerelease': {
     name: 'Angular CLI Prerelease (Webpack | TypeScript)',
     script:
       'npx -p `@angular/cli`@next ng new angular-v16 --directory {{beforeDir}} --routing=true --minimal=true --style=scss --strict --skip-git --skip-install --package-manager=yarn --ssr',
     modifications: {
-      // extraDependencies: ['@standard-schema/spec@^1', '@angular/forms@next'],
+      // TODO: Re-enable once <issue/reason> is resolved. See https://github.com/storybookjs/storybook/issues/XXXXX
+      // extraDependencies: ['@standard-schema/spec@^1', '@angular/forms@next'],
       useCsfFactory: true,
     },

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e0f8b0a and 908d8ba.

📒 Files selected for processing (1)
  • code/lib/cli-storybook/src/sandbox-templates.ts
🧰 Additional context used
📓 Path-based instructions (5)
**/*.{js,jsx,ts,tsx,json,md,html,css,scss}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Format code using Prettier with yarn prettier --write <file>

Files:

  • code/lib/cli-storybook/src/sandbox-templates.ts
**/*.{js,jsx,json,html,ts,tsx,mjs}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Run ESLint checks using yarn lint:js:cmd <file> or the full command cross-env NODE_ENV=production eslint --cache --cache-location=../.cache/eslint --ext .js,.jsx,.json,.html,.ts,.tsx,.mjs --report-unused-disable-directives to fix linting errors before committing

Files:

  • code/lib/cli-storybook/src/sandbox-templates.ts
**/*.{ts,tsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Enable TypeScript strict mode across all packages

Files:

  • code/lib/cli-storybook/src/sandbox-templates.ts
**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

**/*.{ts,tsx,js,jsx}: Export functions from modules if they need to be tested
Do not use console.log, console.warn, or console.error directly unless in isolated files where importing loggers would significantly increase bundle size

Files:

  • code/lib/cli-storybook/src/sandbox-templates.ts
code/{core,lib,addons,builders,frameworks,presets}/**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Use logger from storybook/internal/node-logger for server-side logging in Node.js code

Files:

  • code/lib/cli-storybook/src/sandbox-templates.ts
🧠 Learnings (3)
📚 Learning: 2025-09-24T09:39:39.233Z
Learnt from: ndelangen
Repo: storybookjs/storybook PR: 32507
File: code/core/src/manager/globals/globals-module-info.ts:25-33
Timestamp: 2025-09-24T09:39:39.233Z
Learning: In Storybook, storybook/actions/decorator is a preview-only entrypoint and should not be included in manager globals configuration. The duplicatedKeys array in code/core/src/manager/globals/globals-module-info.ts is specifically for manager-side externalization, not preview entrypoints.

Applied to files:

  • code/lib/cli-storybook/src/sandbox-templates.ts
📚 Learning: 2025-09-29T13:20:23.346Z
Learnt from: mrginglymus
Repo: storybookjs/storybook PR: 32556
File: code/core/package.json:309-313
Timestamp: 2025-09-29T13:20:23.346Z
Learning: The `fast-printf` dependency in Storybook's core package is bundled into the final distribution during the build process, so it should remain in devDependencies rather than being moved to dependencies, following the same pattern as other bundled dependencies like `open`.

Applied to files:

  • code/lib/cli-storybook/src/sandbox-templates.ts
📚 Learning: 2025-09-17T07:31:04.432Z
Learnt from: ndelangen
Repo: storybookjs/storybook PR: 32484
File: code/core/package.json:326-326
Timestamp: 2025-09-17T07:31:04.432Z
Learning: In Storybook's core package, dependencies like `open` are bundled into the final distribution during the build process, so they should remain in devDependencies rather than being moved to dependencies. End users don't need these packages as separate runtime dependencies since they're included in the bundled code.

Applied to files:

  • code/lib/cli-storybook/src/sandbox-templates.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: normal-generated

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@ndelangen ndelangen requested a review from yannbf January 15, 2026 14:38
@ndelangen ndelangen merged commit 8486c72 into next Jan 15, 2026
124 of 134 checks passed
@ndelangen ndelangen deleted the norbert/fix-angular-prerelease branch January 15, 2026 15:01
@github-actions github-actions Bot mentioned this pull request Jan 15, 2026
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

angular build Internal-facing build tooling & test updates ci:normal Run our default set of CI jobs (choose this for most PRs).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant