Tanstack: Export TanStackPreview from @storybook/tanstack-react to unblock CSF Next typing#34949
Open
Copilot wants to merge 2 commits into
Open
Tanstack: Export TanStackPreview from @storybook/tanstack-react to unblock CSF Next typing#34949Copilot wants to merge 2 commits into
TanStackPreview from @storybook/tanstack-react to unblock CSF Next typing#34949Copilot wants to merge 2 commits into
Conversation
Co-authored-by: valentinpalkovic <5889929+valentinpalkovic@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issue with TanstackPreview export in CSF Next
Export May 28, 2026
TanStackPreview from @storybook/tanstack-react to unblock CSF Next typing
huang-julien
approved these changes
May 28, 2026
TanStackPreview from @storybook/tanstack-react to unblock CSF Next typingTanStackPreview from @storybook/tanstack-react to unblock CSF Next typing
Contributor
Contributor
|
Actionable comments posted: 0 |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesTanStackPreview public API
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related issues
Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@storybook/tanstack-reactexposeddefinePreview()returningTanStackPreview<...>, butTanStackPreviewitself was not exported. In consumer projects, this made declaration emit fail withTS4023when exporting apreviewvalue.Type export alignment
TanStackPreviewfrom the framework entrypoint so the public return type ofdefinePreview()is externally nameable.code/frameworks/tanstack-react/src/index.tsPublic API impact
Summary by CodeRabbit