CSF: Export type to prevent `type cannot be named`-errors by unional · Pull Request #33216 · storybookjs/storybook

unional · 2025-11-28T08:52:54Z

Fix type cannot be named error for

defineMain() and meta.story()

Closes #32898

What I did

Re-export missing types

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

Not in automated tests, Couldn't find a way to generate the build result (not the pseudo dist in the monorepo) to test against.

stories
unit tests
integration tests
end-to-end tests

Manual testing

The one for defineMain is pretty easy to validate.
The global types I cannot fully vet it as it depends on the final build tool.
But it should work. I tested it directly in the resulting dist/index.d.ts.

The issue can be repro (and tested manually in):
https://github.com/cyberuni/sb-composite

Documentation

Add or update documentation reflecting your changes
If you are deprecating/removing a feature, make sure to update
MIGRATION.MD

Checklist for Maintainers

When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
- bug: Internal changes that fixes incorrect behavior.
- maintenance: User-facing maintenance tasks.
- dependencies: Upgrading (sometimes downgrading) dependencies.
- build: Internal-facing build tooling & test updates. Will not show up in release changelog.
- cleanup: Minor cleanup style change. Will not show up in release changelog.
- documentation: Documentation only changes. Will not show up in release changelog.
- feature request: Introducing a new feature.
- BREAKING CHANGE: Changes that break compatibility in some way with current major version.
- other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

New Features
- Expanded TypeScript type exports across Storybook addons and framework integrations, enabling developers to import additional configuration and global types directly from their respective packages for improved type safety and IDE support.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

This address the "type cannot be named" error for `defineMain()`.

Fix `meta.story()` type cannot be named error

nx-cloud · 2025-11-28T08:59:54Z

View your CI Pipeline Execution ↗ for commit d3704dd

Command	Status	Duration	Result
`nx run-many -t compile --parallel=3`	✅ Succeeded	45s	View ↗

☁️ Nx Cloud last updated this comment at 2025-12-02 08:20:05 UTC

unional · 2025-11-28T10:15:12Z

You can see the patch that fixed the issue here: https://github.com/cyberuni/sb-composite/tree/issues-32898-patch

mrginglymus · 2025-11-30T21:06:21Z

Also fixes #30579 :)

ndelangen · 2025-12-02T07:52:03Z

 export function defineMain(config: StorybookConfig) {
  return config;
 }
+
+export type { StorybookConfig };


If we explicitly stated the return type, would the type export still be needed? @kasperpeulen

coderabbitai · 2025-12-02T07:55:59Z

📝 Walkthrough

Walkthrough

This change expands the public type surface across addon and framework modules by adding new *Globals type exports and StorybookConfig type exports. All changes are type-only re-exports with no modifications to runtime behavior or control flow.

Changes

Cohort / File(s)	Change Summary
A11y addon types `code/addons/a11y/src/index.ts`	Added `A11yGlobals` to exported type re-exports alongside existing `A11yTypes`
Core addon types `code/core/src/backgrounds/preview.ts`, `code/core/src/viewport/preview.ts`	Added `BackgroundsGlobals` and `ViewportGlobals` to exported type re-exports alongside existing type exports
Framework node index types `code/frameworks/*/src/node/index.ts`	Added `StorybookConfig` type export to 13 framework modules: `angular`, `ember`, `html-vite`, `nextjs`, `preact-vite`, `react-native-web-vite`, `react-vite`, `react-webpack5`, `server-webpack5`, `svelte-vite`, `sveltekit`, `vue3-vite`, `web-components-vite`

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Highly homogeneous changes: identical pattern applied across 16 files (adding single type re-exports)
No logic density, no behavioral changes, no complex interdependencies
Simple verification: confirm types exist in source modules and re-export statements follow TypeScript conventions

✨ Finishing touches

📝 Generate docstrings

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f6604f0 and eff8e92.

📒 Files selected for processing (16)

code/addons/a11y/src/index.ts (1 hunks)
code/core/src/backgrounds/preview.ts (2 hunks)
code/core/src/viewport/preview.ts (1 hunks)
code/frameworks/angular/src/node/index.ts (1 hunks)
code/frameworks/ember/src/node/index.ts (1 hunks)
code/frameworks/html-vite/src/node/index.ts (1 hunks)
code/frameworks/nextjs/src/node/index.ts (1 hunks)
code/frameworks/preact-vite/src/node/index.ts (1 hunks)
code/frameworks/react-native-web-vite/src/node/index.ts (1 hunks)
code/frameworks/react-vite/src/node/index.ts (1 hunks)
code/frameworks/react-webpack5/src/node/index.ts (1 hunks)
code/frameworks/server-webpack5/src/node/index.ts (1 hunks)
code/frameworks/svelte-vite/src/node/index.ts (1 hunks)
code/frameworks/sveltekit/src/node/index.ts (1 hunks)
code/frameworks/vue3-vite/src/node/index.ts (1 hunks)
code/frameworks/web-components-vite/src/node/index.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (5)

**/*.{js,jsx,json,html,ts,tsx,mjs}