Build: Preapprove Storybook packages for yarn npmMinimalAgeGate in sandboxes#34842
Closed
valentinpalkovic wants to merge 2 commits into
Closed
Build: Preapprove Storybook packages for yarn npmMinimalAgeGate in sandboxes#34842valentinpalkovic wants to merge 2 commits into
valentinpalkovic wants to merge 2 commits into
Conversation
…ndboxes Yarn 4.15.0 enables `npmMinimalAgeGate: 1d` by default, which quarantines freshly-published packages from the local Verdaccio registry and breaks sandbox creation (e.g. `create-storybook@10.5.0-alpha.0`). Tighten the gate to 7 days for unknown third-party packages but preapprove every Storybook monorepo package (derived from `versions.ts`) plus the known satellite `@chromatic-com/storybook`.
Reuse `code/core/src/common/satellite-addons.ts` for the sandbox yarn `npmPreapprovedPackages` list and add `vite-plugin-storybook-nextjs` to it so all known Storybook-maintained satellites are covered by both the CLI satellite-addons list and the sandbox preapproval logic.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughAdds Yarn 2 sandbox settings: a 7-day npm age gate and a JSON-stringified preapproved package allowlist built from Storybook package keys plus satellite addons; also appends these settings to the install command sequence and adds 'vite-plugin-storybook-nextjs' to the satellite addons list. ChangesYarn sandbox package age gate configuration
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Comment |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Yarn 4.15.0 enables
npmMinimalAgeGate: 1dby default (yarnpkg/berry#7135), which quarantines freshly-published packages from the local Verdaccio registry and breaks sandbox creation:This PR configures the sandbox yarn install (
scripts/utils/yarn.ts → installYarn2) to:10080minutes) — stricter than yarn's new1ddefault for unknown third-party packages.code/core/src/common/versions.ts) plus the known satellite@chromatic-com/storybook, so freshly-released sandbox packages aren't blocked.The package list stays in sync as packages are added to or removed from
versions.ts.Test plan
next)yarn task sandbox --template react-vite/default-ts --start-from autocompletes withoutYN0016.yarnrc.ymlin the sandbox containsnpmMinimalAgeGate: 10080andnpmPreapprovedPackageswith the Storybook package listSummary by CodeRabbit