Sandboxes: Fix yarn utility#32551
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThe change updates scripts/utils/yarn.ts to unconditionally remove Sequence Diagram(s)sequenceDiagram
autonumber
actor Caller
participant Y as installYarn2 (scripts/utils/yarn.ts)
participant FS as rm(".yarnrc.yml")
participant I as Yarn v2 Installer
Caller->>Y: invoke installYarn2()
rect rgba(200, 230, 255, 0.30)
note right of Y: Pre-install cleanup (new)
Y->>FS: rm(join(cwd, '.yarnrc.yml'), { force: true })
FS-->>Y: resolve (no-op if absent)
end
Y->>I: proceed with Yarn 2 installation
I-->>Y: installation complete
Y-->>Caller: resolve
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
scripts/utils/yarn.ts(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: docs
- GitHub Check: Danger JS
- GitHub Check: Core Unit Tests, windows-latest
🔇 Additional comments (1)
scripts/utils/yarn.ts (1)
1-1: LGTM: Use native fs.rmImporting rm from node:fs/promises is appropriate here.
|
View your CI Pipeline Execution ↗ for commit 90f8bd8
☁️ Nx Cloud last updated this comment at |
…b.com/storybookjs/storybook into norbert/improve-sandboxes-yarn-script
What I did
During assisting @gossi with getting Storybook for Ember back on track, we discovered that the sandboxes contains a
.yarnrc.ymlfile which points to a non-existent path.Somehow that's never been a problem, but somehow it was on his.
Deleting the file solves it.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Summary by CodeRabbit