Core: Use UndoIcon for Review-changes clear button#34767
Open
valentinpalkovic wants to merge 1 commit into
Open
Core: Use UndoIcon for Review-changes clear button#34767valentinpalkovic wants to merge 1 commit into
valentinpalkovic wants to merge 1 commit into
Conversation
Replace the close icon next to the active Review-changes CTA with the undo icon to better convey that clicking reverts the filter.
Contributor
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughReviewChangesButton component updates its "Clear" action icon from CloseIcon to UndoIcon. The import statement and rendered icon are both changed to reflect the new visual representation. ChangesIcon Replacement
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CloseIcontoUndoIconto better convey that clicking reverts the filter.Test plan
yarn storybook:ui, enable change detection, click the Review CTA, and confirm the adjacent button now renders the undo icon.🤖 Generated with Claude Code
Summary by CodeRabbit