Skip to content

Core: Use UndoIcon for Review-changes clear button#34767

Open
valentinpalkovic wants to merge 1 commit into
nextfrom
valentin/change-detection-undo-icon
Open

Core: Use UndoIcon for Review-changes clear button#34767
valentinpalkovic wants to merge 1 commit into
nextfrom
valentin/change-detection-undo-icon

Conversation

@valentinpalkovic
Copy link
Copy Markdown
Contributor

@valentinpalkovic valentinpalkovic commented May 11, 2026

Summary

  • Swap the clear icon next to the active "Reviewing … stories" CTA from CloseIcon to UndoIcon to better convey that clicking reverts the filter.

Test plan

  • Start yarn storybook:ui, enable change detection, click the Review CTA, and confirm the adjacent button now renders the undo icon.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Style
    • Updated the icon displayed for clearing review changes.

Review Change Stack

Replace the close icon next to the active Review-changes CTA with
the undo icon to better convey that clicking reverts the filter.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 11, 2026

Fails
🚫 PR description is missing the mandatory "#### Manual testing" section. Please add it so that reviewers know how to manually test your changes.

Generated by 🚫 dangerJS against b779fb7

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 11, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6263244f-6242-46ff-93c8-a8bbfbc82bd7

📥 Commits

Reviewing files that changed from the base of the PR and between 0eab5b5 and b779fb7.

📒 Files selected for processing (1)
  • code/core/src/manager/components/sidebar/ReviewChangesButton.tsx

📝 Walkthrough

Walkthrough

ReviewChangesButton component updates its "Clear" action icon from CloseIcon to UndoIcon. The import statement and rendered icon are both changed to reflect the new visual representation.

Changes

Icon Replacement

Layer / File(s) Summary
Icon Import and Render
code/core/src/manager/components/sidebar/ReviewChangesButton.tsx
Swaps icon import from CloseIcon to UndoIcon and updates the rendered icon in the active "Clear" button.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant