Skip to content

Core: Quiet change-detection regex warning and swap clear icon#34758

Merged
valentinpalkovic merged 1 commit into
nextfrom
valentin/change-detection-log-and-icon-cleanup
May 11, 2026
Merged

Core: Quiet change-detection regex warning and swap clear icon#34758
valentinpalkovic merged 1 commit into
nextfrom
valentin/change-detection-log-and-icon-cleanup

Conversation

@valentinpalkovic
Copy link
Copy Markdown
Contributor

@valentinpalkovic valentinpalkovic commented May 11, 2026

Summary

  • Demote the regex-alias log in ResolverFactory from logger.warn to logger.debug so it no longer surfaces in the default terminal output.
  • Replace SweepIcon with CloseIcon next to the "Reviewing … stories" CTA in the sidebar so the clear button reads as an x.

Test plan

  • Start yarn storybook:ui, enable change detection, confirm the clear button shows an x icon and no longer the sweep icon.
  • Run a sandbox that triggers regex aliases; verify the Change detection: ignored … line only appears when DEBUG logging is enabled.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Style
    • Updated the icon for the "Clear" action in the review changes interface.

Review Change Stack

Demote the regex-alias warning to debug so it does not show up in the
terminal by default, and replace the sweep icon next to the
Review-changes CTA with a close icon.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 11, 2026

Fails
🚫 PR description is missing the mandatory "#### Manual testing" section. Please add it so that reviewers know how to manually test your changes.

Generated by 🚫 dangerJS against f003ca4

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 11, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ad47983f-e9a7-4ee8-9175-427ea85fcb39

📥 Commits

Reviewing files that changed from the base of the PR and between 4fd4885 and f003ca4.

📒 Files selected for processing (2)
  • code/core/src/core-server/change-detection/dependency-graph/ResolverFactory.ts
  • code/core/src/manager/components/sidebar/ReviewChangesButton.tsx

📝 Walkthrough

Walkthrough

Two independent changes: resolver dependency analysis downgrades regex alias logging to debug level, and the ReviewChangesButton component swaps its "Clear" action icon from SweepIcon to CloseIcon.

Changes

Logging and UI Icon Updates

Layer / File(s) Summary
Resolver Alias Logging Level
code/core/src/core-server/change-detection/dependency-graph/ResolverFactory.ts
AliasNormalizer.normalize emits the "ignored regex alias(es)" message at debug level instead of warn level.
ReviewChangesButton Icon
code/core/src/manager/components/sidebar/ReviewChangesButton.tsx
Icon import and button render updated to use CloseIcon instead of SweepIcon for the "Clear" action.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Comment @coderabbitai help to get the list of available commands and usage tips.

@valentinpalkovic valentinpalkovic merged commit 6178a06 into next May 11, 2026
143 of 149 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/change-detection-log-and-icon-cleanup branch May 11, 2026 09:20
@github-actions github-actions Bot mentioned this pull request May 11, 2026
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants