Skip to content

Build: Actually disable formatting of version json files#34363

Merged
JReinhold merged 1 commit into
nextfrom
fix-versions-formatting
Mar 27, 2026
Merged

Build: Actually disable formatting of version json files#34363
JReinhold merged 1 commit into
nextfrom
fix-versions-formatting

Conversation

@JReinhold
Copy link
Copy Markdown
Contributor

@JReinhold JReinhold commented Mar 27, 2026

Closes #

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

Caution

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • Chores
    • Updated development tool configuration to exclude documentation version files from formatting checks, removing previous exemption patterns.

@JReinhold JReinhold self-assigned this Mar 27, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 27, 2026

Fails
🚫

PR is not labeled with one of: ["ci:normal","ci:merged","ci:daily","ci:docs"]

🚫 The "#### Manual testing" section must be filled in. Please describe how to test the changes you've made, step by step, so that reviewers can confirm your PR works as intended.

Generated by 🚫 dangerJS against 36244e8

@JReinhold JReinhold added the build Internal-facing build tooling & test updates label Mar 27, 2026
@JReinhold JReinhold merged commit 73349ee into next Mar 27, 2026
15 of 16 checks passed
@JReinhold JReinhold deleted the fix-versions-formatting branch March 27, 2026 10:16
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 27, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6414d8ac-86a3-429e-bd57-4bca44d4909e

📥 Commits

Reviewing files that changed from the base of the PR and between 3a6f204 and 36244e8.

📒 Files selected for processing (1)
  • .oxfmtrc.json

📝 Walkthrough

Walkthrough

The pull request updates the formatter configuration file .oxfmtrc.json to ignore JSON files in the docs/versions/ directory from formatting checks by adding a pattern to ignorePatterns and removing its corresponding negation rule.

Changes

Cohort / File(s) Summary
Formatter Configuration
.oxfmtrc.json
Added docs/versions/*.json to ignorePatterns and removed the negation pattern !docs/versions/*.json, ensuring version JSON files are excluded from formatting.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs


Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot mentioned this pull request Mar 27, 2026
18 tasks
@valentinpalkovic valentinpalkovic added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Apr 2, 2026
@github-actions github-actions Bot mentioned this pull request Apr 2, 2026
6 tasks
JReinhold added a commit that referenced this pull request Apr 7, 2026
Build: Actually disable formatting of version json files
(cherry picked from commit 73349ee)
@github-actions github-actions Bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants