Skip to content

Build: Don't check format of version JSON files#34321

Merged
JReinhold merged 2 commits into
nextfrom
jeppe/fix-release-format
Mar 26, 2026
Merged

Build: Don't check format of version JSON files#34321
JReinhold merged 2 commits into
nextfrom
jeppe/fix-release-format

Conversation

@JReinhold
Copy link
Copy Markdown
Contributor

@JReinhold JReinhold commented Mar 25, 2026

Closes #

What I did

These files are written by our release scripts, and their formatting doesn't matter, but they are now failing, which is blocking our release.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

Caution

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • Chores
    • Updated formatter configuration to also ignore docs/versions/*.json while preserving existing exclusion of docs/_snippets/**

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 25, 2026

Fails
🚫 The "#### Manual testing" section must be filled in. Please describe how to test the changes you've made, step by step, so that reviewers can confirm your PR works as intended.

Generated by 🚫 dangerJS against 1a90d3b

@JReinhold JReinhold self-assigned this Mar 25, 2026
@JReinhold JReinhold added build Internal-facing build tooling & test updates ci:normal Run our default set of CI jobs (choose this for most PRs). labels Mar 25, 2026
@JReinhold JReinhold requested a review from huang-julien March 25, 2026 14:25
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Mar 25, 2026

View your CI Pipeline Execution ↗ for commit 1a90d3b

Command Status Duration Result
nx run-many -t compile,check,knip,test,lint,fmt... ✅ Succeeded 1m 2s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-25 14:45:08 UTC

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 859eb400-3206-4401-adc3-1488b2ea98a8

📥 Commits

Reviewing files that changed from the base of the PR and between a72ebc8 and 1a90d3b.

📒 Files selected for processing (1)
  • .oxfmtrc.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • .oxfmtrc.json

📝 Walkthrough

Walkthrough

Updated .oxfmtrc.json to add docs/versions/*.json to ignorePatterns; no other configuration or overrides changes were made.

Changes

Cohort / File(s) Summary
Configuration
​.oxfmtrc.json
Added docs/versions/*.json to ignorePatterns; no changes to overrides or other formatter options.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.oxfmtrc.json:
- Line 40: In the ignorePatterns array remove the unsupported negation prefix by
changing entries like "!docs/versions/*.json" (and the similar
"!docs/_snippets/**") to "docs/versions/*.json" and "docs/_snippets/**"
respectively so the patterns correctly exclude those files; update the
ignorePatterns key accordingly.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 15e77d69-0f34-4e35-970b-670f4547b0dc

📥 Commits

Reviewing files that changed from the base of the PR and between 3f91f48 and a72ebc8.

📒 Files selected for processing (1)
  • .oxfmtrc.json

Comment thread .oxfmtrc.json
@JReinhold JReinhold merged commit f6a6ba7 into next Mar 26, 2026
124 of 125 checks passed
@JReinhold JReinhold deleted the jeppe/fix-release-format branch March 26, 2026 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates ci:normal Run our default set of CI jobs (choose this for most PRs).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants