UI: Hide addon panel Drag on pages without a panel#34162
Conversation
|
View your CI Pipeline Execution ↗ for commit b2f06b9
☁️ Nx Cloud last updated this comment at |
|
View your CI Pipeline Execution ↗ for commit b2f06b9
☁️ Nx Cloud last updated this comment at |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughRefactors the render gate for PanelContainer in desktop view by moving the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
✨ Finishing Touches
📝 Coding Plan
Comment Tip CodeRabbit can approve the review once all CodeRabbit's comments are resolved.Enable the |
10.3 QA bugfix: Ensures the addon panel's resize drag is hidden on Docs or settings pages where there cannot be an addon panel.
The
showPanellogic used to be true when the panel was 0px, making it unsuitable at the time to decide when to hide or show the Drag handle. Now, it only is true when the panel effectively must not be showable at all; so it's safe to use to also hide the Drag.Manual testing
Summary by CodeRabbit