Skip to content

UI: Hide addon panel Drag on pages without a panel#34162

Merged
Sidnioulz merged 1 commit intonextfrom
sidnioulz/10-3-resize-tooltip-bug
Mar 17, 2026
Merged

UI: Hide addon panel Drag on pages without a panel#34162
Sidnioulz merged 1 commit intonextfrom
sidnioulz/10-3-resize-tooltip-bug

Conversation

@Sidnioulz
Copy link
Copy Markdown
Member

@Sidnioulz Sidnioulz commented Mar 16, 2026

10.3 QA bugfix: Ensures the addon panel's resize drag is hidden on Docs or settings pages where there cannot be an addon panel.

The showPanel logic used to be true when the panel was 0px, making it unsuitable at the time to decide when to hide or show the Drag handle. Now, it only is true when the panel effectively must not be showable at all; so it's safe to use to also hide the Drag.

Manual testing

  1. Visit http://localhost:6006/?path=/settings/about
  2. Tab all the way to the bottom of the page content
  3. Keep tabbing and notice no resize handle shows up

Summary by CodeRabbit

  • Refactor
    • Optimized panel rendering logic in desktop layout for improved performance.

@Sidnioulz Sidnioulz requested a review from yannbf March 16, 2026 18:26
@Sidnioulz Sidnioulz added bug ci:normal upgrade:10.3 Issues/PRs found during 10.3 upgrade QA and post-release regressions labels Mar 16, 2026
@nx-cloud
Copy link
Copy Markdown

nx-cloud bot commented Mar 16, 2026

View your CI Pipeline Execution ↗ for commit b2f06b9

Command Status Duration Result
nx run-many -t compile -c production --parallel=1 ✅ Succeeded 4m 38s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-16 18:40:57 UTC

@nx-cloud
Copy link
Copy Markdown

nx-cloud bot commented Mar 16, 2026

View your CI Pipeline Execution ↗ for commit b2f06b9

Command Status Duration Result
nx run-many -t compile -c production --parallel=1 ✅ Succeeded 4m 38s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-16 18:34:20 UTC

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e7891585-fe99-46c0-adb2-4bf5d62e7d49

📥 Commits

Reviewing files that changed from the base of the PR and between 546aece and b2f06b9.

📒 Files selected for processing (1)
  • code/core/src/manager/components/layout/Layout.tsx

📝 Walkthrough

Walkthrough

Refactors the render gate for PanelContainer in desktop view by moving the showPanel check from inside the component's children to the outer conditional. PanelContainer now renders only when both isDesktop and showPanel are true, eliminating a redundant guard inside.

Changes

Cohort / File(s) Summary
Panel Container Render Gate Refactoring
code/core/src/manager/components/layout/Layout.tsx
Moved showPanel condition to outer render gate for PanelContainer; removed redundant showPanel check inside PanelContainer's children, simplifying conditional logic for desktop panel visibility.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can approve the review once all CodeRabbit's comments are resolved.

Enable the reviews.request_changes_workflow setting to automatically approve the review once all CodeRabbit's comments are resolved.

@Sidnioulz Sidnioulz merged commit 90d86a1 into next Mar 17, 2026
126 of 139 checks passed
@Sidnioulz Sidnioulz deleted the sidnioulz/10-3-resize-tooltip-bug branch March 17, 2026 15:45
@github-actions github-actions bot mentioned this pull request Mar 17, 2026
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug ci:normal upgrade:10.3 Issues/PRs found during 10.3 upgrade QA and post-release regressions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants