Skip to content

Tests: Fix Layout story unduly failing#34072

Merged
Sidnioulz merged 1 commit into
nextfrom
fix-layout-story-failure
Mar 9, 2026
Merged

Tests: Fix Layout story unduly failing#34072
Sidnioulz merged 1 commit into
nextfrom
fix-layout-story-failure

Conversation

@Sidnioulz
Copy link
Copy Markdown
Member

@Sidnioulz Sidnioulz commented Mar 9, 2026

What I did

A recent PR introduced a change that breaks a layout story even though the PR CI is green.

This fixes the story to match with my expectation.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

  1. Visit http://localhost:6006/?path=/story/manager-layout--desktop-collapsed-panel
  2. Notice play function passes

Documentation

ø

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • Tests
    • Updated the collapsed panel component validation to verify complete removal from the DOM instead of checking for zero-height rendering and focus behavior.

@Sidnioulz Sidnioulz added build Internal-facing build tooling & test updates ci:normal labels Mar 9, 2026
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Mar 9, 2026

View your CI Pipeline Execution ↗ for commit 7adec54

Command Status Duration Result
nx run-many -t compile -c production --parallel=1 ✅ Succeeded 5m 13s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-09 07:56:45 UTC

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 68b10220-bd46-4bea-b7e7-4293cd88ad6f

📥 Commits

Reviewing files that changed from the base of the PR and between 533dcc0 and 7adec54.

📒 Files selected for processing (1)
  • code/core/src/manager/components/layout/Layout.stories.tsx

📝 Walkthrough

Walkthrough

The change modifies test assertions in the DesktopCollapsedPanel Storybook story, replacing separate checks for collapsed rendering (zero height and no focus capability) with a single assertion that validates the panel element is entirely absent from the DOM.

Changes

Cohort / File(s) Summary
DesktopCollapsedPanel Story Assertions
code/core/src/manager/components/layout/Layout.stories.tsx
Replaced two assertions checking panel height and focus state with a single assertion validating panel DOM absence via queryByTestId.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

@Sidnioulz Sidnioulz changed the title Fix Layout story unduly failing Tests: Fix Layout story unduly failing Mar 9, 2026
@Sidnioulz Sidnioulz merged commit 0096e34 into next Mar 9, 2026
124 of 133 checks passed
@Sidnioulz Sidnioulz deleted the fix-layout-story-failure branch March 9, 2026 10:36
@github-actions github-actions Bot mentioned this pull request Mar 9, 2026
31 tasks
@github-actions github-actions Bot mentioned this pull request Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates ci:normal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants