Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions code/core/src/bin/core.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { getEnvConfig, optionalEnvToBoolean, parseList } from 'storybook/interna
import { logTracker, logger } from 'storybook/internal/node-logger';
import { addToGlobalContext } from 'storybook/internal/telemetry';

import { program } from 'commander';
import { Option, program } from 'commander';
import leven from 'leven';
import picocolors from 'picocolors';

Expand Down Expand Up @@ -45,17 +45,20 @@ const command = (name: string) =>
)
.option('--debug', 'Get more logs in debug mode', false)
.option('--enable-crash-reports', 'Enable sending crash reports to telemetry data')
.option('--loglevel <trace | debug | info | warn | error | silent>', 'Define log level', 'info')
.addOption(
new Option('--loglevel <level>', 'Define log level')
.choices(['trace', 'debug', 'info', 'warn', 'error', 'silent'])
.default('info')
)
.option(
'--logfile [path]',
'Write all debug logs to the specified file at the end of the run. Defaults to debug-storybook.log when [path] is not provided'
)
.hook('preAction', async (self) => {
try {
const options = self.opts();
if (options.loglevel) {
logger.setLogLevel(options.loglevel);
}
const loglevel = options.debug ? 'debug' : options.loglevel;
logger.setLogLevel(loglevel);

if (options.logfile) {
logTracker.enableLogWriting();
Expand Down
17 changes: 17 additions & 0 deletions code/core/src/node-logger/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,23 @@ describe('node-logger', () => {
logger.warn(message);
expect(loggerMock.warn).toHaveBeenCalledWith(message);
});

it('should sync --loglevel with npmlog', () => {
logger.setLogLevel('debug');
expect(npmlog.level).toBe('verbose');
expect(loggerMock.setLogLevel).toHaveBeenCalledWith('debug');

logger.setLogLevel('trace');
expect(npmlog.level).toBe('silly');
expect(loggerMock.setLogLevel).toHaveBeenCalledWith('trace');
});

it('should keep setLevel and setLogLevel consistent', () => {
logger.setLevel('warn');
expect(npmlog.level).toBe('warn');
expect(loggerMock.setLogLevel).toHaveBeenCalledWith('warn');
});

it('should have an error method', () => {
const message = 'error message';
logger.error(message);
Expand Down
22 changes: 18 additions & 4 deletions code/core/src/node-logger/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,22 @@ export type { LogLevel } from './logger/logger';
// there are issues with the build: https://github.com/storybookjs/storybook/issues/14621
npmLog.stream = process.stdout;

const toNpmLogLevel = (level: newLogger.LogLevel): string => {
switch (level) {
case 'trace':
return 'silly';
case 'debug':
return 'verbose';
default:
return level;
}
};

const setLoggerLevel = (level: newLogger.LogLevel = 'info'): void => {
npmLog.level = toNpmLogLevel(level);
newLogger.setLogLevel(level);
};

function hex(hexColor: string) {
// Ensure the hex color is 6 characters long and starts with '#'
if (!/^#?[0-9A-Fa-f]{6}$/.test(hexColor)) {
Expand Down Expand Up @@ -57,10 +73,8 @@ export const logger = {
warn: (message: string): void => newLogger.warn(message),
trace: ({ message, time }: { message: string; time: [number, number] }): void =>
newLogger.debug(`${message} (${colors.purple(prettyTime(time))})`),
setLevel: (level: newLogger.LogLevel = 'info'): void => {
npmLog.level = level;
newLogger.setLogLevel(level);
},
setLevel: setLoggerLevel,
setLogLevel: setLoggerLevel,
error: (message: unknown): void => {
let msg: string;
if (message instanceof Error && message.stack) {
Expand Down
Loading