Logger: Honor --loglevel for npmlog output#33776
Merged
valentinpalkovic merged 1 commit intoFeb 5, 2026
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughRefactored CLI log level option using Commander's Option API with explicit choices and default values. Introduced log level translation mapping between internal log levels and npm-log equivalents, centralized level management logic, and added synchronization tests. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Author
|
Friendly ping for review when you have time — this aligns |
valentinpalkovic
approved these changes
Feb 5, 2026
This was referenced Feb 5, 2026
Merged
valentinpalkovic
added a commit
that referenced
this pull request
Feb 5, 2026
Logger: honor --loglevel for npmlog output (cherry picked from commit 02fdf2a)
This was referenced Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22061.
logger.setLogLevelupdates both the new logger and the legacynpmloginstance (with sensible level mapping: trace->silly, debug->verbose).--debugactually take effect (forces loglevel=debug).--loglevelvalues via commander choices.Tests:
Summary by CodeRabbit
Bug Fixes
Tests